-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed old LazyGetter calls from HLTDummyCollections #11810
Removed old LazyGetter calls from HLTDummyCollections #11810
Conversation
The module HLTDummyCollections is the last module to produce LazyGetter objects. The SiStrip case was changed to match the modern class type used. the ECal was commented out since it is unclear what is the proper replacement since the module label that was used by the HLTDummyCollections when delivering ECal hits is no longer associated to an existing module type.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Removed old LazyGetter calls from HLTDummyCollections It involves the following packages: HLTrigger/special @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…Collections Removed old LazyGetter calls from HLTDummyCollections
The module HLTDummyCollections is the last module to produce LazyGetter
objects. The SiStrip case was changed to match the modern class type
used. the ECal was commented out since it is unclear what is the proper
replacement since the module label that was used by the HLTDummyCollections
when delivering ECal hits is no longer associated to an existing module
type.