Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastsim: HF: use shower library also for run1 #11783

Merged
merged 4 commits into from
Oct 22, 2015
Merged

Fastsim: HF: use shower library also for run1 #11783

merged 4 commits into from
Oct 22, 2015

Conversation

lveldere
Copy link
Contributor

rebase of #11674

@lveldere
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 14, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8808/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_6_X.

Fastsim: HF: use shower library also for run1

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/Event
SLHCUpgradeSimulations/Configuration

@cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: 56e5573
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11783/8808/summary.html

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8850/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 56e5573
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11783/8850/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11783/8850/summary.html

@lveldere
Copy link
Contributor Author

thanks @smuzaffar

@lveldere
Copy link
Contributor Author

+1

changes in workflow 5.1 expected (HF model and sim particle selection have changed for run1)
no changes in workflow 135.4, as expected (changes do not affect run2 era)

@civanch
Copy link
Contributor

civanch commented Oct 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild cmsbuild mentioned this pull request Oct 19, 2015
Merged
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 22, 2015
@cmsbuild
Merge pull request #11783 from lveldere/fastsim-hf-sl-run1-take2
7c3fcc3 
Fastsim: HF: use shower library also for run1
@cmsbuild cmsbuild merged commit 7c3fcc3 into cms-sw:CMSSW_7_6_X Oct 22, 2015
@lveldere lveldere deleted the fastsim-hf-sl-run1-take2 branch November 9, 2015 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fastsim-approved fully-signed simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
5 participants
@lveldere @cmsbuild @smuzaffar @civanch @davidlange6