Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default HBHENoiseFilter settings to Run2-25ns configuration - 76X #11778

Conversation

dertexaner
Copy link
Contributor

This is to switch the default HBHENoiseFilterResultProducer settings to Run2-25ns configuration such that users get correct noise flags out of the box for the bulk of 2015 data (and beyond) which is with 25ns bunch spacing.
@abdoulline @igv4321 @mariadalfonso

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dertexaner for CMSSW_7_6_X.

Switch default HBHENoiseFilter settings to Run2-25ns configuration - 76X

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 14, 2015

there are merge conflicts

More importantly, I'd like to ask for a coded switch using bunchSpacing
the following can be used as an example
https://github.com/cms-sw/cmssw/blob/CMSSW_7_6_X/RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitWorkerMultiFit.cc#L44
the default would be to rely on the bunchSpacing product value stored in the event.

@slava77
Copy link
Contributor

slava77 commented Oct 15, 2015

-1
@dertexaner please close this PR, it's superseded by #11789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants