Tuning the CSC Halo filter parameters #11737
Conversation
…e rate, only consider out of time hits in the calo-csc matching)
|
A new Pull Request was created by @lathomas for CMSSW_7_6_X. Tuning the CSC Halo filter parameters It involves the following packages: RecoMET/METAlgorithms @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: b43386b ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
I get the following error: An exception of category 'ProductNotFound' occurred while => This does not seem related to any changes I did. Any clue where the error comes from? |
|
+1 Small adjustments to the CSC beam halo filter. #11136 and #11137 are related PRs to which this change has been added for 74X and 75X. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-12-1100 show no significant differences. The unit test error in Jenkins is not related to this PR. A test of wokflows 25202.0_TTbar_13 with 70 events against baseline CMSSW_7_6_0_pre6 also shows no significant differences. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: b43386b ---> test testRecoMETMETProducers had ERRORS you can see the results of the tests here: |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Tuning the CSC Halo filter parameters
The parameters used in the filters are retuned to decrease the fake rate.
Most of the changes are described here:
https://indico.cern.ch/event/451934/contribution/8/attachments/1167422/1683679/beamhalo_Laurent.pdf
(Notice that some parameters are slightly different from those quoted there, because the fake rate was found to be worse than expected).
Only out of time rechits are now considered in the CSC-calo matching.
In the same spirit, late CSC segments (t>15 ns), which are unlikely compatible with the beam halo hypothesis, are discarded.