Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Tau and Jet calibration LUTs, and emulation algorithm fixe… #11253

Merged
merged 1 commit into from
Sep 15, 2015
Merged

Updates to Tau and Jet calibration LUTs, and emulation algorithm fixe… #11253

merged 1 commit into from
Sep 15, 2015

Conversation

mulhearn
Copy link
Contributor

Updates to Tau and Jet LUTs, and emulator fixes to improve agreement with firmware. Requires a cms-data PR.

@mulhearn
Updates to Tau and Jet calibration LUTs, and emulation algorithm fixe…
5b1778d 
…s, for improved agreement with latest firmware
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 15, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_7_6_X.

Updates to Tau and Jet calibration LUTs, and emulation algorithm fixe

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor Author

Actually, seems the cms-data PR was already done...

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

This was referenced Sep 15, 2015
Closed
Closed
@cmsbuild
Copy link
Contributor

+1
Tested at: 5b1778d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11253/8081/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 15, 2015
@cmsbuild
Merge pull request #11253 from cms-l1t-offline/l1t-lutupdates-76X-nodata
0a6bc35 
Updates to Tau and Jet calibration LUTs, and emulation algorithm fixe…
@cmsbuild cmsbuild merged commit 0a6bc35 into cms-sw:CMSSW_7_6_X Sep 15, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11253/8081/summary.html

@mulhearn mulhearn mentioned this pull request Sep 22, 2015
Closed
mulhearn added a commit to cms-l1t-offline/cmssw that referenced this pull request Sep 23, 2015
@mulhearn
Cherry-picked minimum set of changes to get PR cms-sw#11253 to compil…
875741b 
…e in 74X.

bbcafca
bbcafca
This was referenced Sep 23, 2015
Merged
Merged
cmsbuild added a commit that referenced this pull request Oct 21, 2015
@cmsbuild
Merge pull request #11437 from cms-l1t-offline/l1t-lutupdates-75X-nodata
5a16934 
Backport of PR #11253 to 75X - Updates to Tau and Jet calibration LUT, Alg fixes
cmsbuild added a commit that referenced this pull request Oct 27, 2015
@cmsbuild
Merge pull request #11435 from cms-l1t-offline/l1t-lutupdates-74X-nodata
61d26b5 
Backport of PR #11253 - Updates to Tau and Jet calibration LUT, Alg fixes
@mulhearn mulhearn deleted the l1t-lutupdates-76X-nodata branch February 11, 2016 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed l1-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
3 participants
@mulhearn @cmsbuild @davidlange6