Fixed checksum upload validation when compressing LHE files #11088
Conversation
Script only gets the checksum of the files being added to EOS. When compressing LHE files with the previous behavior, the script added a checksum for both the original .lhe file and the compressed .lhe.xz. Therefore, it would not compare the correct checksum to the file in EOS and and always produce a warning if the compression option was used.
|
A new Pull Request was created by @davidsheffield (David Sheffield) for CMSSW_7_1_X. Fixed checksum upload validation when compressing LHE files It involves the following packages: GeneratorInterface/LHEInterface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks. |
|
Except I would suggest a bump in version number (1.13 -> 1.14), the new script works fine for me (tested on eos article 15447) could this be merged ? It is a quite useful check for every single new pLHE request that goes into MCM... |
|
+1 |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
I'll add a pull request for 8_0_X now that it's the working release. Should I update the version number in 8_0_X if it isn't updated here? |
|
It is ok to leave the old one, I don't know who introduced this numbering but it is much better to keep track of changes via git commits |
|
Comparison is ready @slava77 there are some missing matrix maps:
|
|
+1 |
Fixed checksum upload validation when compressing LHE files
Backport of #9396.
Script only gets the checksum of the files being added to EOS.
When compressing LHE files with the previous behavior, the script added a checksum for both the original .lhe file and the compressed .lhe.xz. Therefore, it would not compare the correct checksum to the file in EOS and and always produce a warning if the compression option was used.
Previously it checked:
eos/file1.lhe.xz <-> local/file1.lhe
eos/file2.lhe.xz <-> local/file1.lhe.xz
eos/file3.lhe.xz <-> local/file2.lhe
eos/file4.lhe.xz <-> local/file2.lhe.xz
etc.
Now it checks
eos/file1.lhe.xz <-> local/file1.lhe.xz
eos/file2.lhe.xz <-> local/file2.lhe.xz
eos/file3.lhe.xz <-> local/file3.lhe.xz
eos/file4.lhe.xz <-> local/file4.lhe.xz
etc.