Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpaka package fails to compile for ROCm when it has only .dev.cc files #44506

Closed
makortel opened this issue Mar 21, 2024 · 11 comments · Fixed by cms-sw/cmssw-config#107 or cms-sw/cmsdist#9102

Comments

@makortel
Copy link
Contributor

From https://mattermost.web.cern.ch/cms-o-and-c/pl/5dncb3ojnfgyxdd93113z6bsdw

A package with

`-- HeterogeneousCore
    `-- AlpakaTest
        |-- BuildFile.xml
        |-- interface
        |   `-- alpaka
        |       |-- AlpakaESTestData.h
        |       `-- TestAlgo.h
        `-- src
            `-- alpaka
                `-- TestAlgo.dev.cc

fails to compile HeterogeneousCore/AlpakaTest/src/alpaka/TestAlgo.dev.cc for ROCm backend

Unknow target tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaTest/src/alpaka/HeterogeneousCoreAlpakaTestROCmAsync/TestAlgo.dev.cc.o
@makortel
Copy link
Contributor Author

assign core, heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: core,heterogeneous

@Dr15Jones,@fwyzard,@makortel,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @makortel.

@rappoccio, @sextonkennedy, @Dr15Jones, @smuzaffar, @antoniovilela, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@ariostas
Copy link
Contributor

Just to add a bit more context (since I think the title is a bit misleading), the issue happens when building a library with any .dev.cc files. Currently, the Alpaka libraries that are built only compile .cc files, which is why this issue hasn't come up before.

@makortel makortel changed the title Alpaka package fails to compile for ROCm when it has only one source file Alpaka package fails to compile for ROCm when it has only .dev.cc files Mar 25, 2024
@makortel
Copy link
Contributor Author

Just to add a bit more context (since I think the title is a bit misleading), the issue happens when building a library with any .dev.cc files. Currently, the Alpaka libraries that are built only compile .cc files, which is why this issue hasn't come up before.

Thanks, I updated the title.

@makortel
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

@fwyzard
Copy link
Contributor

fwyzard commented Apr 4, 2024

@smuzaffar, do you know if this fix entered CMSSW_14_1_0_pre2 or only afterwards ?
What about CMSSW_14_0_4 ?

@smuzaffar
Copy link
Contributor

@fwyzard
CMSSW_14_1_0_pre2: No, fix was merged after pre2
CMSSW_14_0_4 : Yes, fix is part of this release

@fwyzard
Copy link
Contributor

fwyzard commented Apr 4, 2024

OK, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants