-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre/post signals for write-lumi and write-run #28555
Comments
A new Issue was created by @makortel Matti Kortelainen. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign core |
New categories assigned: core @Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Just to confirm: this is exactly what I wanted to request in #28521. |
Accomplished with #28562 |
+1 |
This issue is fully signed and ready to be closed. |
In the context of #28521 @Dr15Jones and I realized that while the framework emits pre/post signals for globalEndLumi before/after the global end-lumi functions of all modules (including output) have been called, there are no signals for the subsequent write-lumi transitions (same holds for run).
We came to the conclusion that it would be beneficial to add pre/post signals for write-lumi and write-run in order to let other parts know when the processing of lumis and runs are fully done.
The text was updated successfully, but these errors were encountered: