Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre/post signals for write-lumi and write-run #28555

Closed
makortel opened this issue Dec 4, 2019 · 7 comments
Closed

Add pre/post signals for write-lumi and write-run #28555

makortel opened this issue Dec 4, 2019 · 7 comments

Comments

@makortel
Copy link
Contributor

makortel commented Dec 4, 2019

In the context of #28521 @Dr15Jones and I realized that while the framework emits pre/post signals for globalEndLumi before/after the global end-lumi functions of all modules (including output) have been called, there are no signals for the subsequent write-lumi transitions (same holds for run).

We came to the conclusion that it would be beneficial to add pre/post signals for write-lumi and write-run in order to let other parts know when the processing of lumis and runs are fully done.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

A new Issue was created by @makortel Matti Kortelainen.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

assign core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@schneiml
Copy link
Contributor

schneiml commented Dec 5, 2019

Just to confirm: this is exactly what I wanted to request in #28521.

@Dr15Jones
Copy link
Contributor

Accomplished with #28562

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2019

This issue is fully signed and ready to be closed.

@makortel makortel closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants