-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use edm::one modules to access PoolDBOutputService #18340
Labels
Comments
A new Issue was created by @Dr15Jones Chris Jones. @davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign alca |
unassign alca
|
assign db |
New categories assigned: db @ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+db |
This issue is fully signed and ready to be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
PoolDBOutputService
appears to be properly thread safe by using astd::mutex
. However, since the framework will still schedule multiple modules to run concurrently where those modules would then be fighting over the mutex lock and therefore some of them would stall. If, instead, the modules would be declarededm::one
modules and would declare aSharedResource
on thePoolDBOutputService
, the framework would schedule only one module to talk to the service at a time and could run other modules concurrently which do not need the service.Such a change is made easier because many of the modules that use the
PoolDBOutputService
appear to be templated classes:BoostIODBWriter<>
,ConditionDBWriter<>
andDummyCondDBWriter<>
.The text was updated successfully, but these errors were encountered: