Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondCore/CondDB/test/testConnectionPool.cpp accessing obsolete squid service #18246

Closed
DrDaveD opened this issue Apr 6, 2017 · 10 comments
Closed

Comments

@DrDaveD
Copy link

DrDaveD commented Apr 6, 2017

CondCore/CondDB/test/testConnectionPool.cpp has a hardcoded frontier configuration, proxyconfigurl=http://cmst0frontier.cern.ch/t0.pac, and that is now obsolete and will soon be decomissioned. The new proxyconfigurl is http://grid-wpad/wpad.dat, but more importantly, why is that connect string hardcoded there at all? It should be using the local configuration from site-local-config.xml like everything else.

Please look at this at high priority, or these tests will start failing soon.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

A new Issue was created by @DrDaveD .

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

davidlange6 commented Apr 6, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

New categories assigned: db

@ggovi you have been requested to review this Pull request/Issue and eventually sign? Thanks

@DrDaveD
Copy link
Author

DrDaveD commented Apr 17, 2017

@ggovi Please look at this with high priority. The t0.pac interface will soon be decomissioned and I assume all tests running this code will start breaking.

@ggovi
Copy link
Contributor

ggovi commented Apr 18, 2017

@DrDaveD
Thanks for the warning. Addressed by
#18376
#18377
#18378
Concerning the need to have the full string in the test: here we validate the code parsing and decoding various connection string supported. The explicit frontier connection string, although discouraged, is supported.

@DrDaveD
Copy link
Author

DrDaveD commented Apr 18, 2017

Thanks, @ggovi. Do you know if this test is run only on the latest code? Or is it also run on old code? Clearly it has to be run only at CERN since a CERN configuration is hard-coded.

@ggovi
Copy link
Contributor

ggovi commented Apr 18, 2017

I found this test in 80X, 90X and 91X ( not in 71X ). Any other release cycle to check?

@DrDaveD
Copy link
Author

DrDaveD commented Apr 19, 2017

It's good to hear that it doesn't go back to very old code. I just hope that people aren't using it for older released versions in those release cycles, but instead are only using it with the latest integration builds.

@ggovi
Copy link
Contributor

ggovi commented Nov 14, 2017

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants