Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROOTMaster] Updated root to tip of branch master #9627

Closed
wants to merge 1 commit into from
Closed

[ROOTMaster] Updated root to tip of branch master #9627

wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_15_0_X/rootmaster.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 20, 2025 •
edited
Loading

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test for CMSSW_15_0_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-276a04/43859/summary.html
COMMIT: 1b6998b
CMSSW: CMSSW_15_0_ROOT6_X_2025-01-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43859/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/DataFormats/HcalIsolatedTrack/src/IsolatedPixelTrackCandidate.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_ROOT6_X_2025-01-19-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_ROOT6_X_2025-01-19-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02873/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_ROOT6_X_2025-01-19-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.1.0-8e7128ba865cc169d302ab17150849de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-24621bb5019ee7e7984682e0f80b5fcf/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls/2019.08-e6beae7d560007d8bb20c2cf88bfde9a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-d947221dfef9ef0f4c58e17a5214a16a/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-573155027234b8f945d29403a2749d52/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/IsolatedPixelTrackCandidate.cc.d src/DataFormats/HcalIsolatedTrack/src/IsolatedPixelTrackCandidate.cc -o tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/IsolatedPixelTrackCandidate.cc.o
>> Building LCG reflex dict from header file src/DataFormats/HcalIsolatedTrack/src/classes.h
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-d947221dfef9ef0f4c58e17a5214a16a/bin/rootcling -reflex -f tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc -inlineInputHeader -failOnWarnings -rmf tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.rootmap -rml libDataFormatsHcalIsolatedTrack.so -m DataFormatsRecoCandidate_xr_rdict.pcm -m DataFormatsEgammaReco_xr_rdict.pcm -m DataFormatsGsfTrackReco_xr_rdict.pcm -m DataFormatsTrackReco_xr_rdict.pcm -m DataFormatsTrackCandidate_xr_rdict.pcm -m DataFormatsTrajectorySeed_xr_rdict.pcm -m DataFormatsL1Trigger_xr_rdict.pcm -m DataFormatsTrackingRecHit_xr_rdict.pcm -m DataFormatsL1TrackTrigger_xr_rdict.pcm -m DataFormatsTrackerCommon_xr_rdict.pcm -m DataFormatsBeamSpot_xr_rdict.pcm -m DataFormatsCaloTowers_xr_rdict.pcm -m DataFormatsEcalRecHit_xr_rdict.pcm -m DataFormatsGeometryCommonDetAlgo_xr_rdict.pcm -m DataFormatsSiStripCluster_xr_rdict.pcm -m DataFormatsCandidate_xr_rdict.pcm -m DataFormatsEcalDigi_xr_rdict.pcm -m DataFormatsGeometrySurface_xr_rdict.pcm -m DataFormatsL1GlobalCaloTrigger_xr_rdict.pcm -m DataFormatsTrajectoryState_xr_rdict.pcm -m DataFormatsCLHEP_xr_rdict.pcm -m DataFormatsCaloRecHit_xr_rdict.pcm -m DataFormatsEcalDetId_xr_rdict.pcm -m DataFormatsForwardDetId_xr_rdict.pcm -m DataFormatsGeometryVector_xr_rdict.pcm -m DataFormatsHcalDetId_xr_rdict.pcm -m DataFormatsL1CaloTrigger_xr_rdict.pcm -m DataFormatsMuonDetId_xr_rdict.pcm -m DataFormatsSiPixelDetId_xr_rdict.pcm -m DataFormatsSiStripDetId_xr_rdict.pcm -m DataFormatsDetId_xr_rdict.pcm -m DataFormatsL1GlobalMuonTrigger_xr_rdict.pcm -m DataFormatsMath_xr_rdict.pcm -m DataFormatsPhase2TrackerDigi_xr_rdict.pcm -m DataFormatsScouting_xr_rdict.pcm -m DataFormatsSiPixelCluster_xr_rdict.pcm -m DataFormatsSiStripDigi_xr_rdict.pcm -m DataFormatsCommon_xr_rdict.pcm -m DataFormatsProvenance_xr_rdict.pcm -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH="CMSSW_15_0_ROOT6_X_2025-01-19-2300" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_15_0_ROOT6_X_2025-01-19-2300" -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02873/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_ROOT6_X_2025-01-19-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.1.0-8e7128ba865cc169d302ab17150849de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-24621bb5019ee7e7984682e0f80b5fcf/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls/2019.08-e6beae7d560007d8bb20c2cf88bfde9a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-d947221dfef9ef0f4c58e17a5214a16a/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-573155027234b8f945d29403a2749d52/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT src/DataFormats/HcalIsolatedTrack/src/classes.h src/DataFormats/HcalIsolatedTrack/src/classes_def.xml
Warning: 2 Rule(s) for target class reco::LeafParticle was not used!
gmake: *** [tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc] Error 1
>> Compiling  LCG dictionary: tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc.d -I. -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_15_0_ROOT6_X_2025-01-19-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_0_ROOT6_X_2025-01-19-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02873/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_ROOT6_X_2025-01-19-2300/src -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.1.0-8e7128ba865cc169d302ab17150849de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-24621bb5019ee7e7984682e0f80b5fcf/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/clhep/2.4.7.1-d3a3e353d370e701238f7949a0d7909f/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gsl/2.6-f7574c606b0ce57ff601d3ca9534cd01/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls/2019.08-e6beae7d560007d8bb20c2cf88bfde9a/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.35.1-d947221dfef9ef0f4c58e17a5214a16a/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2021.9.0-573155027234b8f945d29403a2749d52/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-e265b266d2b30c1bebdd883980d0f9d0/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/OpenBLAS/0.3.27-70a9dd2c9f309171934f13e3003b0540/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-f99ae2781d074227d47e8a3e7c8ec87e/include -DCMSSW_REFLEX_DICT -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -Os -Wno-unused-variable -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc -o tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc.o
cc1plus: fatal error: tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc: No such file or directory
compilation terminated.
gmake: *** [tmp/el8_amd64_gcc12/src/DataFormats/HcalIsolatedTrack/src/DataFormatsHcalIsolatedTrack/lcgdict/DataFormatsHcalIsolatedTrack_xr.cc.o] Error 1

@iarspider
Copy link
Contributor Author

Failure reported: root-project/root#17347 (comment)

@smuzaffar
Copy link
Contributor

@makortel , any idea how to fix this (see root-project/root#17347 (comment))? targetClass="reco::LeafParticle" at https://github.com/cms-sw/cmssw/blob/master/DataFormats/HcalIsolatedTrack/src/classes_def.xml#L26-L31 is not in cmssw.

@smuzaffar
Copy link
Contributor

@makortel , any idea how to fix this (see root-project/root#17347 (comment))? targetClass="reco::LeafParticle" at https://github.com/cms-sw/cmssw/blob/master/DataFormats/HcalIsolatedTrack/src/classes_def.xml#L26-L31 is not in cmssw.

any idea @makortel @Dr15Jones ?

@makortel
Copy link
Contributor

The iorule was first added in 623a1b1. There was no LeafParticle in CMSSW even at that time. I see reco::EcalIsolatedParticleCandidate inherits from reco::LeafCandidate, maybe that was meant at the time? I see an earlier commit f925130 that removes the double eta_ member of reco::EcalIsolatedParticleCandidate in favor of the float eta_ member of the reco::LeafCandidate, so I suppose the intent of the iorule was to address that. I don't remember if ROOT's automatic schema evolution should be able to deal with that.

Given that

I'd just remove the iorule.

@smuzaffar smuzaffar mentioned this pull request Jan 22, 2025
Merged
@smuzaffar
Copy link
Contributor

please test with cms-sw/cmssw#47162 for CMSSW_15_0_ROOT6_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-276a04/43912/summary.html
COMMIT: 1b6998b
CMSSW: CMSSW_15_0_ROOT6_X_2025-01-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 15 errors in the following unit tests:

---> test testSiStripHitEfficiency had ERRORS
---> test testSSTGainPCL_fromRECO had ERRORS
---> test testHeterogeneousCoreCUDATestWriteRead had ERRORS
and more ...

RelVals

  • 4.22A fatal system signal has occurred: segmentation violation
  • 1000.0A fatal system signal has occurred: segmentation violation
  • 1001.0A fatal system signal has occurred: segmentation violation

AddOn Tests

A fatal system signal has occurred: segmentation violation

----- Begin Fatal Exception 22-Jan-2025 19:12:07 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'p'
   [2] Prefetching for module CandidateSummaryTable/'selectedPatCandidateSummary'
   [3] Prefetching for module PATJetSelector/'selectedPatJets'
   [4] Prefetching for module PATJetProducer/'patJets'
   [5] While reading from source std::vector<reco::PFJet> ak4PFJetsCHS '' RECO
   [6] Rethrowing an exception that happened on a different read request.
   [7] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [8] Running path 'p'
   [9] Prefetching for module CandidateSummaryTable/'selectedPatCandidateSummary'
   [10] Prefetching for module PATElectronSelector/'selectedPatElectrons'
   [11] Prefetching for module PATElectronProducer/'patElectrons'
   [12] While reading from source std::vector<reco::Conversion> allConversions '' RECO
   [13] Reading branch recoConversions_allConversions__RECO.
   Additional Info:
      [a] Fatal Root Error: @SUB=UpdateFromRule
For reco::HitPattern::hitCount the number of array elements in the rule (50) does not match the number in the StreamerElement (0)

----- End Fatal Exception -------------------------------------------------

@makortel
Copy link
Contributor

makortel commented Jan 23, 2025 •
edited
Loading

This update seems to break many things

Read rule of CUDA-specific PortableHostCollection (that is to be phased out) crashes along (HeterogeneousCore/CUDATest/test/testHeterogeneousCoreCUDATestWriteRead) (curiously the Alpaka-based version works)

#2  0x000014993143d574 in sig_dostack_then_abort () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#3  <signal handler called>
#4  0x000014992ee792ec in ROOT::read_cmscLcLcudacLcLPortableHostCollectionlEportabletestcLcLTestSoALayoutlE128cOfalsegRsPgR_0(char*, TVirtualObject*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/libCUDADataFormatsPortableTestObjects.so
#5  0x0000149930958e2d in int TStreamerInfo::ReadBufferArtificial<char**>(TBuffer&, char** const&, TStreamerElement*, int, int) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#6  0x0000149930a1c08e in int TStreamerInfo::ReadBuffer<char**>(TBuffer&, char** const&, TStreamerInfo::TCompInfo* const*, int, int, int, int, int) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#7  0x00001499307f385d in TStreamerInfoActions::GenericReadAction(TBuffer&, void*, TStreamerInfoActions::TConfiguration const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#8  0x0000149930722afe in TBufferFile::ReadClassBuffer(TClass const*, void*, TClass const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#9  0x000014993081f819 in TStreamerInfoActions::ReadViaClassBuffer(TBuffer&, void*, TStreamerInfoActions::TConfiguration const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#10 0x000014993071a235 in TBufferFile::ApplySequence(TStreamerInfoActions::TActionSequence const&, void*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#11 0x0000149930d20ae0 in TBranchElement::ReadLeavesMember(TBuffer&) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#12 0x0000149930d19179 in TBranch::GetEntry(long long, int) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#13 0x0000149930d2c644 in TBranchElement::GetEntry(long long, int) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#14 0x0000149930d2c5fd in TBranchElement::GetEntry(long long, int) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#15 0x00001499105cf7ac in edm::RootTree::getEntry(TBranch*, long long) const () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#16 0x00001499105aeae8 in edm::RootDelayedReader::getProduct_(edm::BranchID const&, edm::EDProductGetter const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#17 0x0000149938d3314b in edm::DelayedReader::getProduct(edm::BranchID const&, edm::EDProductGetter const*, edm::ModuleCallingContext const*) () from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/libFWCoreFramework.so

Reading old files with reco::HitPattern (old files from 9_2_X, 8_0_X, 10_2_X, 7_3_X) fail with exception along

----- Begin Fatal Exception 22-Jan-2025 19:05:17 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 1 lumi: 38 event: 1851 stream: 0
   [1] Running path 'p'
   [2] Prefetching for module ShallowEventDataProducer/'shallowEventRun'
   [3] While reading from source std::vector<LumiScalers> scalersRawToDigi '' RECO
   [4] Rethrowing an exception that happened on a different read request.
   [5] Processing  Event run: 1 lumi: 38 event: 1851 stream: 0
   [6] Running path 'p'
   [7] Prefetching for module ShallowTracksProducer/'shallowTracks'
   [8] While reading from source std::vector<reco::Track> generalTracks '' RECO
   [9] Reading branch recoTracks_generalTracks__RECO.
   Additional Info:
      [a] Fatal Root Error: @SUB=UpdateFromRule
For reco::HitPattern::hitCount the number of array elements in the rule (50) does not match the number in the StreamerElement (0)

----- End Fatal Exception -------------------------------------------------

Reading RAW file from 2010 (CMSSW 3_5_X or 3_6_X) crashes with (log) or from 2011 (CMSSW 4_1_X or 4_2_X)

#2  0x000014f9bb6ce574 in sig_dostack_then_abort () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/pluginFWCoreServicesPlugins.so
#3  <signal handler called>
#4  0x000014f9c314f856 in TStreamerSTL::GetClassPointer() const () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libCore.so
#5  0x000014f9c314ce22 in TStreamerElement::Init(TVirtualStreamerInfo*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libCore.so
#6  0x000014f9babe81f5 in TStreamerInfo::BuildOld() () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#7  0x000014f9babeccd3 in TStreamerInfo::BuildOld() () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#8  0x000014f9c310e4bc in TClass::FindStreamerInfo(unsigned int, bool) const () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libCore.so
#9  0x000014f9bab20c9d in TBufferFile::ReadVersion(unsigned int*, unsigned int*, TClass const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#10 0x000014f9bab22989 in TBufferFile::ReadClassBuffer(TClass const*, void*, TClass const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#11 0x000014f9bac1f819 in TStreamerInfoActions::ReadViaClassBuffer(TBuffer&, void*, TStreamerInfoActions::TConfiguration const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#12 0x000014f9bab22afe in TBufferFile::ReadClassBuffer(TClass const*, void*, TClass const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#13 0x000014f9bab9f2a0 in TGenCollectionStreamer::ReadObjects(int, TBuffer&, TClass const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#14 0x000014f9baba0667 in TGenCollectionStreamer::ReadBufferGeneric(TBuffer&, void*, TClass const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#15 0x000014f9bab1b569 in TBufferFile::ReadFastArray(void*, TClass const*, int, TMemberStreamer*, TClass const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#16 0x000014f9bad0e245 in int TStreamerInfoActions::ReadSTL<&TStreamerInfoActions::ReadSTLMemberWiseSameClass, &TStreamerInfoActions::ReadSTLObjectWiseFastArray>(TBuffer&, void*, TStreamerInfoActions::TConfiguration const*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#17 0x000014f9bab1a235 in TBufferFile::ApplySequence(TStreamerInfoActions::TActionSequence const&, void*) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libRIO.so
#18 0x000014f9bb569ae0 in TBranchElement::ReadLeavesMember(TBuffer&) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#19 0x000014f9bb562179 in TBranch::GetEntry(long long, int) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#20 0x000014f9bb575644 in TBranchElement::GetEntry(long long, int) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/external/el8_amd64_gcc12/lib/libTree.so
#21 0x000014f99a9d0201 in edm::roottree::getEntry(TBranch*, long long) () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so
#22 0x000014f99a9cb574 in edm::FullProvenanceReader::readProvenance(unsigned int) const () from /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43912/CMSSW_15_0_ROOT6_X_2025-01-21-2300/lib/el8_amd64_gcc12/pluginIOPoolInput.so

@pcanal How should we proceed? Should we e.g. open issue(s) to ROOT GitHub (one issue or separate issues)?

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test for CMSSW_15_0_ROOT6_X

lets rerun tests with full CMSSW rebuild

@pcanal
Copy link

pcanal commented Jan 23, 2025

Most likely we need to fix the rule in question. in libCUDADataFormatsPortableTestObjects.so (maybe) there seems to be a rule on 'reco::HitPattern::hitCount', can you point that one out and can you give me the StreamerInfo for reco::HitPattern on the file being read?

@smuzaffar
Copy link
Contributor

@pcanal , https://github.com/cms-sw/cmssw/blob/master/DataFormats/TrackReco/src/classes_def.xml contains the ioread rule for reco::HitPattern

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-276a04/43923/summary.html
COMMIT: 1b6998b
CMSSW: CMSSW_15_0_ROOT6_X_2025-01-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9627/43923/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 15 errors in the following unit tests:

---> test testSiStripHitEfficiency had ERRORS
---> test testSSTGainPCL_fromRECO had ERRORS
---> test testHeterogeneousCoreCUDATestWriteRead had ERRORS
and more ...

RelVals

  • 4.22A fatal system signal has occurred: segmentation violation
  • 1000.0A fatal system signal has occurred: segmentation violation
  • 1001.0A fatal system signal has occurred: segmentation violation

AddOn Tests

A fatal system signal has occurred: segmentation violation

----- Begin Fatal Exception 23-Jan-2025 11:51:09 CET-----------------------
An exception of category 'FileReadError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'p'
   [2] Prefetching for module CandidateSummaryTable/'selectedPatCandidateSummary'
   [3] Prefetching for module PATJetSelector/'selectedPatJets'
   [4] Prefetching for module PATJetProducer/'patJets'
   [5] While reading from source std::vector<reco::PFJet> ak4PFJetsCHS '' RECO
   [6] Rethrowing an exception that happened on a different read request.
   [7] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [8] Running path 'p'
   [9] Prefetching for module CandidateSummaryTable/'selectedPatCandidateSummary'
   [10] Prefetching for module PATElectronSelector/'selectedPatElectrons'
   [11] Prefetching for module PATElectronProducer/'patElectrons'
   [12] While reading from source std::vector<reco::Conversion> allConversions '' RECO
   [13] Reading branch recoConversions_allConversions__RECO.
   Additional Info:
      [a] Fatal Root Error: @SUB=UpdateFromRule
For reco::HitPattern::hitCount the number of array elements in the rule (50) does not match the number in the StreamerElement (0)

----- End Fatal Exception -------------------------------------------------

@pcanal
Copy link

pcanal commented Jan 23, 2025

Do you have a copy of the file being read?

@smuzaffar
Copy link
Contributor

@pcanal , you can find the copy of root file here /afs/cern.ch/user/m/muzaffar/public/root6/EEB99F74-DA4D-E711-A41C-0025905A48F2.root

@pcanal
Copy link

pcanal commented Jan 23, 2025

, cms-sw/cmssw@master/DataFormats/TrackReco/src/classes_def.xml contains the ioread rule for reco::HitPattern

For completeness' sake the rule should list the data member of the schema that are updated by reco::HitPattern::fillNewHitPatternWithOldHitPattern_v12

@makortel makortel mentioned this pull request Jan 23, 2025
Merged
@makortel
Copy link
Contributor

, cms-sw/cmssw@master/DataFormats/TrackReco/src/classes_def.xml contains the ioread rule for reco::HitPattern

For completeness' sake the rule should list the data member of the schema that are updated by reco::HitPattern::fillNewHitPatternWithOldHitPattern_v12

Thanks, I added those in cms-sw/cmssw#47169. I'd expect the two other error cases to be different though (as neither that PortableHostCollection test nor RAW should make use of reco::HitPattern).

@pcanal
Copy link

pcanal commented Jan 24, 2025

I'd expect the two other error cases to be different though

They are. I am able to reproduce:

      [a] Fatal Root Error: @SUB=UpdateFromRule
For reco::HitPattern::hitCount the number of array elements in the rule (50) does not match the number in the StreamerElement (0)

and so I am working on this.

pcanal added a commit to pcanal/root that referenced this pull request Jan 25, 2025
@pcanal
io rules: Prevent dimensions from spilling.
0302d0f 
This solves part 1 at cms-sw/cmsdist#9627 (comment).

without this path all inputs following an array input were wrongly marked as an array.
pcanal added a commit to pcanal/root that referenced this pull request Jan 25, 2025
@pcanal
io rules: Prevent dimensions from spilling.
af8567c 
This solves part 1 at cms-sw/cmsdist#9627 (comment).

without this path all inputs following an array input were wrongly marked as an array.
@pcanal pcanal mentioned this pull request Jan 25, 2025
Merged
pcanal added a commit to root-project/root that referenced this pull request Jan 28, 2025
@pcanal
io rules: Prevent dimensions from spilling.
390d2f0 
This solves part 1 at cms-sw/cmsdist#9627 (comment).

without this path all inputs following an array input were wrongly marked as an array.
@pcanal
Copy link

pcanal commented Jan 28, 2025

@smuzaffar At least one of the problem is solved by root-project/root#17523 which has been merged. Can you retry with it?

@iarspider iarspider mentioned this pull request Jan 29, 2025
Closed
@smuzaffar
Copy link
Contributor

closing it in favor of #9643

@smuzaffar smuzaffar closed this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iarspider @cmsbuild @smuzaffar @makortel @pcanal