Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cms-sw/root#123: 612 backport of I/O rules and splitting improvements. #4784

Closed
cmsbuild opened this issue Mar 15, 2019 · 1 comment
Closed

Comments

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pcanal (Philippe Canal) for branch cms/v6-12-00-patches/3f31cef.

Pull Request Reference: cms-sw/root#123

@smuzaffar, @mrodozov, @gudrutis can you please review it and eventually sign? Thanks.

@cmsbuild
Copy link
Contributor Author

Pull request cms-sw/root#123 was updated.
Latest update by Philippe Canal with commit message
In BuildOld, don't make all unique_ptr as having -> in comment.

unique_ptr can be nullptr too sometimes and anyway TStreamerInfo::Build does not make the same restriction.
The mismatch lead to baffling error message like:

Warning in TStreamerInfo::BuildOld: Cannot convert A::h from type: B to type: B, skip element

This solves one of the problems seen in https://sft.its.cern.ch/jira/browse/ROOT-9702.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants