Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup ele/photons #570

Closed
3 of 10 tasks
mariadalfonso opened this issue Apr 15, 2021 · 2 comments
Closed
3 of 10 tasks

cleanup ele/photons #570

mariadalfonso opened this issue Apr 15, 2021 · 2 comments

Comments

@mariadalfonso
Copy link

mariadalfonso commented Apr 15, 2021

  1. some variable stored might be obsolete
    http://dalfonso.web.cern.ch/dalfonso/XPOG/NANV8/Summer20UL18NanoAODv2_TTToSemiLeptonic_size_report.html#Electron
  • remove Electron_cutBased_Fall17_V1 are not recommended for Run2
  • check who's is using electron_jetRelIso, Electron_jetPtRelv2 are being used for
  1. ALL ph/ele are used
    https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/photons_cff.py#L170-L172
    https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/electrons_cff.py#L310-L312
  • check increase pt: i.e. 10/15 GeV are not used, (BPH used lowPTele from mini)
  • evaluate adding selection i.e. OR of [ID + fakable ID ] can be different per
  1. Some variable might not be needed (see nanov9)
    https://cms-nanoaod-integration.web.cern.ch/integration/cms-swmaster/mc106Xul17v2_size_report.html#Photon
  • Electron_mass 2.3% (similar occupancy as the pt)
  • Photon_mass 3.1% (similar impact of the pt) some non initialised value
    see http://dalfonso.web.cern.ch/dalfonso/NANO/massDump.txt
  • Photon_mvaID_Fall17V1p1 is needed ? Photon_mvaID is already there and correspond to the Fall17V2
  • Electron_dr03TkSumPt is used in the reco chain in PF Egamma Filter (electron ID), but
    Swagata is not sure why it is needed in nano, or if any analysis team is using it or not.
  1. improve self documentation
@mariadalfonso mariadalfonso added this to the NanoAODv9 milestone Apr 15, 2021
@mariadalfonso
Copy link
Author

'remove Electron_cutBased_Fall17_V1 are not recommended for Run2' done in cms-sw/33701

@mariadalfonso mariadalfonso removed this from the NanoAODv9 milestone Jun 8, 2021
@mariadalfonso
Copy link
Author

I close this as a lot of slimming/clearing/renaming was done.
Still the configurations could be simplified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant