Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MTDGeometryBuilder test reference for numerical issues on ARM/MULTIARCHS builds #17

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

fabiocos
Copy link
Contributor

Updated reference to solve unit test failures introduced by cms-sw/cmssw#46683 . In support of cms-sw/cmssw#46761

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

REMINDER @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen: This PR was tested with cms-sw/cmssw#46761, please check if they should be merged together

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = Geometry/MTDGeometryBuilder

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

this has been tested via cmssw PR, so I am merge it now

@smuzaffar
Copy link
Contributor

+externals

Ref data updated used by unit test

@smuzaffar smuzaffar merged commit 5239a08 into cms-data:master Nov 27, 2024
5 of 6 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2d5db5/43112/summary.html
COMMIT: 3371884
CMSSW: CMSSW_15_0_X_2024-11-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/Geometry-TestReference/17/43112/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483717
  • DQMHistoTests: Total failures: 395
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3483302
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants