hotfix: fix dump_dataset in dump_processed.py #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
i think the dump_dataset function did not compare the processed dataset filenames of the coffea output correctly with the dataset json file.
Please verify that the changes work correctly. For me they work now. Previously all files from the json file were listed as failed although they were contained in the coffea output file.
previously the code looked like this
since
list_from_coffea
is instantiated as an empty dictionary, there will be no keys and hencelist_from_coffea
will be filled with empty lists instead of the list from the coffea output