Skip to content

Commit 2c82e91

Browse files
committed
Run tests on PHP 8.4 and update test environment
1 parent 2a5371c commit 2c82e91

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.github/workflows/ci.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ jobs:
1111
strategy:
1212
matrix:
1313
os:
14-
- ubuntu-22.04
14+
- ubuntu-24.04
1515
- windows-2022
1616
php:
17+
- 8.4
18+
- 8.3
1719
- 8.2
1820
- 8.1
1921
- 8.0
@@ -36,8 +38,8 @@ jobs:
3638
extensions: sqlite3
3739
coverage: xdebug
3840
ini-file: development
39-
# disable JIT on PHP 8.2 with Xdebug: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.
40-
ini-values: ${{ matrix.php == 8.2 && 'opcache.jit_buffer_size=0' || '' }}
41+
# disable JIT on PHP 8.2+ with Xdebug: JIT is incompatible with third party extensions that override zend_execute_ex(). JIT disabled.
42+
ini-values: ${{ matrix.php >= 8.2 && 'opcache.jit_buffer_size=0' || '' }}
4143
- run: composer install
4244
- run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml
4345
if: ${{ matrix.php >= 7.3 }}

tests/FunctionalFactoryTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function testOpenReturnsPromiseWhichFulfillsWithConnectionForMemoryPathAn
5252
public function testOpenReturnsPromiseWhichRejectsWithExceptionWhenPathIsInvalid()
5353
{
5454
$factory = new Factory();
55-
$promise = $factory->open('/dev/foobar');
55+
$promise = $factory->open('/dev/foo/bar');
5656

5757
$promise->then(function (DatabaseInterface $db) {
5858
echo 'open.';

tests/Io/BlockingDatabaseTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public function testCtorThrowsForInvalidPath()
1515
// legacy PHPUnit
1616
$this->setExpectedException('Exception');
1717
}
18-
new BlockingDatabase('/dev/foobar');
18+
new BlockingDatabase('/dev/foo/bar');
1919
}
2020

2121
public function testExecReturnsRejectedPromiseForInvalidQuery()

0 commit comments

Comments
 (0)