Skip to content
This repository was archived by the owner on May 24, 2019. It is now read-only.

Commit 090aad5

Browse files
committed
fix tests for 0.8.0 release
1 parent 7abcd90 commit 090aad5

File tree

8 files changed

+79
-79
lines changed

8 files changed

+79
-79
lines changed

DESCRIPTION

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: MTurkR
2-
Version: 0.7.11
3-
Date: 2016-07-26
2+
Version: 0.8.0
3+
Date: 2017-01-22
44
Title: R Client for the MTurk Requester API
55
Authors@R: c(person("Thomas J.", "Leeper", role = c("aut", "cre"),
66
email = "thosjleeper@gmail.com"),

NEWS renamed to NEWS.md

+49-47
Large diffs are not rendered by default.

R/GetStatistic.R

+5-6
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@ statistic <-
33
function (statistic, period = "LifeToDate", count = NULL, response.group = NULL,
44
verbose = getOption('MTurkR.verbose', TRUE), ...) {
55
operation <- "GetRequesterStatistic"
6-
value.long <- c("NumberAssignmentsAvailable", "NumberAssignmentsAccepted",
7-
"NumberAssignmentsPending", "NumberAssignmentsApproved",
8-
"NumberAssignmentsRejected", "NumberAssignmentsReturned",
9-
"NumberAssignmentsAbandoned", "NumberHITsCreated", "NumberHITsCompleted",
6+
value.long <- c("NumberAssignmentsPending", "NumberAssignmentsApproved",
7+
"NumberAssignmentsRejected", "NumberAssignmentsAbandoned",
8+
"NumberHITsCreated", "NumberHITsCompleted",
109
"NumberHITsAssignable", "NumberHITsReviewable")
1110
value.double <- c("PercentAssignmentsApproved", "PercentAssignmentsRejected",
1211
"TotalRewardPayout", "AverageRewardAmount", "TotalRewardFeePayout",
13-
"TotalFeePayout", "TotalRewardAndFeePayout", "TotalBonusPayout",
14-
"TotalBonusFeePayout", "EstimatedRewardLiability", "EstimatedFeeLiability",
12+
"TotalBonusPayout", "TotalBonusFeePayout",
13+
"EstimatedRewardLiability", "EstimatedFeeLiability",
1514
"EstimatedTotalLiability")
1615
if (!statistic %in% value.long & !statistic %in% value.double) {
1716
stop("Statistic not valid")

R/ListStatistics.R

-5
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
ListStatistics <-
22
function (stat = NULL, value.type = NULL, type = NULL) {
33
stats <- setNames(as.data.frame(rbind(
4-
c("NumberAssignmentsAvailable", "Long", "GetRequesterStatistic"),
5-
c("NumberAssignmentsAccepted", "Long", "GetRequesterStatistic"),
64
c("NumberAssignmentsPending", "Long", "GetRequesterStatistic"),
75
c("NumberAssignmentsApproved", "Long", "GetRequesterStatistic"),
86
c("NumberAssignmentsRejected", "Long", "GetRequesterStatistic"),
9-
c("NumberAssignmentsReturned", "Long", "GetRequesterStatistic"),
107
c("NumberAssignmentsAbandoned", "Long", "GetRequesterStatistic"),
118
c("NumberHITsCreated", "Long", "GetRequesterStatistic"),
129
c("NumberHITsCompleted", "Long", "GetRequesterStatistic"),
@@ -17,8 +14,6 @@ function (stat = NULL, value.type = NULL, type = NULL) {
1714
c("TotalRewardPayout", "Double", "GetRequesterStatistic"),
1815
c("AverageRewardAmount", "Double", "GetRequesterStatistic"),
1916
c("TotalRewardFeePayout", "Double", "GetRequesterStatistic"),
20-
c("TotalFeePayout", "Double", "GetRequesterStatistic"),
21-
c("TotalRewardAndFeePayout", "Double", "GetRequesterStatistic"),
2217
c("TotalBonusPayout", "Double", "GetRequesterStatistic"),
2318
c("TotalBonusFeePayout", "Double", "GetRequesterStatistic"),
2419
c("EstimatedRewardLiability", "Double", "GetRequesterStatistic"),

R/RequesterReport.R

+15-11
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,26 @@ function (period = "LifeToDate", verbose = getOption('MTurkR.verbose', TRUE), ..
33
if (!period %in% c("OneDay", "SevenDays", "ThirtyDays", "LifeToDate")) {
44
stop("Period not valid")
55
}
6-
statistics <- c("NumberAssignmentsAvailable", "NumberAssignmentsAccepted",
7-
"NumberAssignmentsPending", "NumberAssignmentsApproved",
8-
"NumberAssignmentsRejected", "NumberAssignmentsReturned",
6+
statistics <- c(
7+
"NumberAssignmentsPending", "NumberAssignmentsApproved", "NumberAssignmentsRejected",
98
"NumberAssignmentsAbandoned", "NumberHITsCreated", "NumberHITsCompleted",
109
"NumberHITsAssignable", "NumberHITsReviewable", "PercentAssignmentsApproved",
1110
"PercentAssignmentsRejected", "TotalRewardPayout", "AverageRewardAmount",
12-
"TotalRewardFeePayout", "TotalFeePayout", "TotalRewardAndFeePayout",
13-
"TotalBonusPayout", "TotalBonusFeePayout", "EstimatedRewardLiability",
11+
"TotalRewardFeePayout", "TotalBonusPayout",
12+
"TotalBonusFeePayout", "EstimatedRewardLiability",
1413
"EstimatedFeeLiability", "EstimatedTotalLiability")
1514
z <- emptydf(length(statistics), 2, c("Statistic", "Value"))
16-
z[, 1] <- statistics
17-
for (i in 1:20) {
18-
z[i, 2] <- GetStatistic(statistics[i], period = period, ...)
15+
z[["Statistic"]] <- statistics
16+
only_ltd <- c("NumberHITsAssignable", "EstimatedRewardLiability", "EstimatedFeeLiability", "EstimatedTotalLiability")
17+
for (i in seq_along(statistics)) {
18+
if (statistics[i] %in% only_ltd) {
19+
if (statistics[i] == "NumberHITsAssignable" && period != "LifeToDate") {
20+
message("'NumberHITsAssignable' is being retrieved for period 'LifeToDate'")
21+
}
22+
z[i, 2] <- GetStatistic(statistics[i], period = "LifeToDate", verbose = verbose, ...)[["Value"]]
23+
} else {
24+
z[i, 2] <- GetStatistic(statistics[i], period = period, verbose = verbose, ...)[["Value"]]
25+
}
1926
}
20-
for (i in 21:23) {
21-
z[i, 2] <- GetStatistic(statistics[i], period = "LifeToDate", ...)
22-
}
2327
return(z)
2428
}

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ If you experience problems using MTurkR, you can:
2525

2626
## Installation ##
2727

28-
[![CRAN Version](http://www.r-pkg.org/badges/version/MTurkR)](http://cran.r-project.org/package=MTurkR)
29-
![Downloads](http://cranlogs.r-pkg.org/badges/MTurkR)
28+
[![CRAN Version](https://www.r-pkg.org/badges/version/MTurkR)](https://cran.r-project.org/package=MTurkR)
29+
![Downloads](https://cranlogs.r-pkg.org/badges/MTurkR)
3030
[![Travis-CI Build Status](https://travis-ci.org/cloudyr/MTurkR.png?branch=master)](https://travis-ci.org/cloudyr/MTurkR)
31-
[![codecov.io](http://codecov.io/github/cloudyr/MTurkR/coverage.svg?branch=master)](http://codecov.io/github/cloudyr/MTurkR?branch=master)
31+
[![codecov.io](https://codecov.io/github/cloudyr/MTurkR/coverage.svg?branch=master)](https://codecov.io/github/cloudyr/MTurkR?branch=master)
3232

3333
To install the latest version from CRAN, simply use:
3434

@@ -43,7 +43,7 @@ To install the latest development version of **MTurkR** from GitHub:
4343
install.packages("MTurkR", repos = c(getOption("repos"), "http://cloudyr.github.io/drat"))
4444

4545
# latest (unstable) version from GitHub
46-
if(!require("ghit")){
46+
if (!require("ghit")) {
4747
install.packages("ghit")
4848
}
4949
ghit::install_github("cloudyr/MTurkR")

man/GetStatistic.Rd

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Retrieve a specific requester or worker statistic. The list of available statist
4747
}
4848
\examples{
4949
\dontrun{
50-
GetStatistic("NumberHITsSubmitted","OneDay")
50+
GetStatistic("NumberHITsCompleted","OneDay")
5151
RequesterReport("ThirtyDays")
5252
GetWorkerStatistic("A1RO9UJNWXMU65","PercentHITsApproved","LifeToDate")
5353
WorkerReport("A1RO9UJNWXMU65","SevenDays")

tests/testthat/tests.R

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ test_that("Account Balance Check", {
99
Sys.sleep(1)
1010

1111
test_that("RequesterReport", {
12-
expect_true(is.data.frame(RequesterReport()))
13-
expect_true(is.data.frame(WorkerReport("A1RO9UJNWXMU65", period = "OneDay", sandbox = TRUE)))
12+
expect_true(is.data.frame(RequesterReport(sandbox = TRUE)))
13+
expect_true(is.data.frame(RequesterReport(period = "OneDay", sandbox = TRUE)))
1414
})
1515

1616
Sys.sleep(1)
1717

18-
test_that("RequesterReport", {
18+
test_that("WorkerReport", {
1919
expect_true(is.data.frame(WorkerReport("A1RO9UJNWXMU65", sandbox = TRUE)))
2020
expect_true(is.data.frame(WorkerReport("A1RO9UJNWXMU65", period = "OneDay", sandbox = TRUE)))
2121
})

0 commit comments

Comments
 (0)