Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Logging configuration for cloudwatch #38

Open
afdecastro879 opened this issue Oct 15, 2024 · 0 comments · May be fixed by #39
Open

Support Logging configuration for cloudwatch #38

afdecastro879 opened this issue Oct 15, 2024 · 0 comments · May be fixed by #39

Comments

@afdecastro879
Copy link

Describe the Feature

Currently this module only supports logging configuration using an s3 bucket. On top of that, the way this module is configuring logging is in process to being deprecated (Check here From the official terraform documentation for the aws_redshift_cluster rescource).
We would like to have support to configure logging with cloudwatch and be able to configure the log_exports exported log types for redshift.

Expected Behavior

A logging with cloudwatch is configured through some variables.

Use Case

I'm migrating some old infrastructure to cloudposse modules, and found that I wasn't able to configure the existing logging behaviour using this module.

Describe Ideal Solution

The ideal solution will have another 2 variables, logging_log_destination_type and logging_log_exports.

The first (logging_log_destination_type) will allow setting either s3 or cloudwatch as the destination type. In the case s3 is selected, then the existing variables logging_bucket_name and logging_s3_key_prefix will take effect, otherwise those values don't need to be configured.

logging_log_exportsonly applies when cloudwatch is selected as logging_log_destination_type and will allow to select the exported log types.

Ideally, this new behaviour is managed via the new aws_redshift_logging terraform resource, replacing the current implementation here

Alternatives Considered

No response

Additional Context

No response

@kristian-lesko kristian-lesko linked a pull request Oct 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant