Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module fails if ES service linked role doesn't exist #44

Closed
joe-niland opened this issue Mar 5, 2020 · 1 comment · Fixed by #46
Closed

Module fails if ES service linked role doesn't exist #44

joe-niland opened this issue Mar 5, 2020 · 1 comment · Fixed by #46
Labels
bug 🐛 An issue with the system

Comments

@joe-niland
Copy link
Member

joe-niland commented Mar 5, 2020

I found that this module wouldn't work unless I created the ES service linked role first (for service "es.amazonaws.com").

The reason for this is that if the role doesn't already exist the data source element fails (https://github.com/cloudposse/terraform-aws-elasticsearch/blob/master/main.tf#L68) and the module won't complete.

The create_iam_service_linked_role variable was added a while ago to deal with this issue, however it seems the variable value is not used.

Expected Behavior

The module should run even if the service linked role doesn't exist

Steps to Reproduce

  1. Include this module, setting variable create_iam_service_linked_role to true
  2. terraform apply

Environment (please complete the following information):

TF 0.12.21

@igable
Copy link
Contributor

igable commented Apr 2, 2020

If anyone is looking for a workaround until this issue is resolved all you need to do is:

aws iam create-service-linked-role --aws-service-name es.amazonaws.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants