Merge pull request #344 from benjaminguttmann-avtq/master

UnhealthyCell metric deprecated in favor of GardenHealthCheckFailed

Author: frodenas

jobs/cloudfoundry_alerts/templates/cf_cells.alerts.yml

@@ -2,7 +2,7 @@ groups:
   - name: cf-cells
     rules:
       - alert: CFCellUnhealthy
-        expr: max(firehose_value_metric_rep_unhealthy_cell) by(environment, bosh_deployment, bosh_job_name, bosh_job_ip) > 0
+        expr: max(firehose_value_metric_rep_garden_health_check_failed) by(environment, bosh_deployment, bosh_job_name, bosh_job_ip) > 0
         for: <%= p('cloudfoundry_alerts.cell_unhealthy.evaluation_time') %>
         labels:
           service: cf

jobs/cloudfoundry_dashboards/templates/cf_cell_summary.json

@@ -144,7 +144,7 @@
       "tableColumn": "",
       "targets": [
         {
-          "expr": "max(firehose_value_metric_rep_unhealthy_cell{environment=~\"$environment\",bosh_deployment=~\"$bosh_deployment\", bosh_job_name=~\"$bosh_job_name\", bosh_job_ip=~\"$bosh_job_ip\"})",
+          "expr": "max(firehose_value_metric_rep_garden_health_check_failed{environment=~\"$environment\",bosh_deployment=~\"$bosh_deployment\", bosh_job_name=~\"$bosh_job_name\", bosh_job_ip=~\"$bosh_job_ip\"})",
           "format": "time_series",
           "intervalFactor": 2,
           "legendFormat": "",

jobs/cloudfoundry_dashboards/templates/cf_diego_health.json

@@ -311,7 +311,7 @@
       "steppedLine": false,
       "targets": [
         {
-          "expr": "max(firehose_value_metric_rep_unhealthy_cell{environment=~\"$environment\",bosh_deployment=~\"$bosh_deployment\"}) by(bosh_deployment, bosh_job_name, bosh_job_ip)",
+          "expr": "max(firehose_value_metric_rep_garden_health_check_failed{environment=~\"$environment\",bosh_deployment=~\"$bosh_deployment\"}) by(bosh_deployment, bosh_job_name, bosh_job_ip)",
           "interval": "",
           "intervalFactor": 2,
           "legendFormat": "{{ bosh_deployment }}/{{ bosh_job_name }}/{{ bosh_job_ip }}",
@@ -379,7 +379,7 @@
         "multi": false,
         "name": "environment",
         "options": [],
-        "query": "label_values(firehose_value_metric_rep_unhealthy_cell, environment)",
+        "query": "label_values(firehose_value_metric_rep_garden_health_check_failed, environment)",
         "refresh": 1,
         "regex": "",
         "sort": 1,
@@ -399,7 +399,7 @@
         "multi": false,
         "name": "bosh_deployment",
         "options": [],
-        "query": "label_values(firehose_value_metric_rep_unhealthy_cell{environment=~\"$environment\"}, bosh_deployment)",
+        "query": "label_values(firehose_value_metric_rep_garden_health_check_failed{environment=~\"$environment\"}, bosh_deployment)",
         "refresh": 1,
         "regex": "",
         "sort": 1,

jobs/cloudfoundry_dashboards/templates/cf_kpis.json

@@ -138,7 +138,7 @@
       "tableColumn": "",
       "targets": [
         {
-          "expr": "count(min(firehose_value_metric_rep_unhealthy_cell{environment=~\"$environment\",bosh_deployment=~\"$bosh_deployment\"}) by(bosh_deployment, bosh_job_name, bosh_job_ip) == 1)",
+          "expr": "count(min(firehose_value_metric_rep_garden_health_check_failed{environment=~\"$environment\",bosh_deployment=~\"$bosh_deployment\"}) by(bosh_deployment, bosh_job_name, bosh_job_ip) == 1)",
           "intervalFactor": 2,
           "refId": "A",
           "step": 60