From 4427710e7f4155424836be0883ea36a00b1260b2 Mon Sep 17 00:00:00 2001 From: Robert Gogolok Date: Thu, 16 May 2024 12:09:50 +0200 Subject: [PATCH] Allow pre-release cli versions --- api/middleware/cli_version.go | 2 +- api/middleware/cli_version_test.go | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/api/middleware/cli_version.go b/api/middleware/cli_version.go index 210205a84..547480ba6 100644 --- a/api/middleware/cli_version.go +++ b/api/middleware/cli_version.go @@ -11,7 +11,7 @@ import ( "github.com/mileusna/useragent" ) -const minSupportedVersion = ">= 8.5.0" +const minSupportedVersion = ">= 8.5.0-0" func CFCliVersion(next http.Handler) http.Handler { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { diff --git a/api/middleware/cli_version_test.go b/api/middleware/cli_version_test.go index 9820fb07d..134c81f69 100644 --- a/api/middleware/cli_version_test.go +++ b/api/middleware/cli_version_test.go @@ -72,6 +72,16 @@ var _ = Describe("CliVersionMiddleware", func() { }) }) + When("the cf cli version is a valid pre-release", func() { + BeforeEach(func() { + requestHeaders["User-Agent"] = []string{"cf/9.0.0-beta+334489f01.2024-05-14 (go1.22.2; arm64 darwin)"} + }) + + It("delegates to the next handler", func() { + Expect(rr).To(HaveHTTPStatus(http.StatusTeapot)) + }) + }) + When("there are multiple UserAgent header values", func() { BeforeEach(func() { requestHeaders["User-Agent"] = []string{