Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support memory definition with lower case letters #3231

Closed
marsteg opened this issue Apr 23, 2024 · 2 comments
Closed

Support memory definition with lower case letters #3231

marsteg opened this issue Apr 23, 2024 · 2 comments
Labels
chore

Comments

@marsteg
Copy link
Contributor

marsteg commented Apr 23, 2024

Background

Motivation
The SJB integration test test-memory-calculation-env defines manifest with memory using lower case letters (memory: 256m). As per the spec both upper and lower case letters should be supported.

Goals
Support lower case letter definition of memory in CF manifests.

Action to take

No response

Impact

low - only extended an existing regex

Dev Notes

No response
@marsteg marsteg added the chore label Apr 23, 2024
@github-project-automation github-project-automation bot moved this to 🧊 Icebox in Korifi - Backlog Apr 23, 2024
@marsteg marsteg mentioned this issue Apr 23, 2024
Merged
@marsteg
Copy link
Contributor Author

marsteg commented Apr 23, 2024

#3232

@marsteg
Copy link
Contributor Author

marsteg commented May 13, 2024

solved by the linked PR #3232

@marsteg marsteg closed this as completed May 13, 2024
@github-project-automation github-project-automation bot moved this from 🧊 Icebox to ✅ Done in Korifi - Backlog May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore
Projects
Korifi - Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marsteg