Use ruby conventions in Bosh::Common internal gem

This work is in preparation for extracting this code to a separate
repository since it is consumed by existing Ruby-based CPI's

Signed-off-by: Brian Upton <brian.upton@broadcom.com>

Author: aramprice

packages/director/spec

@@ -8,6 +8,6 @@ dependencies:
 
 files:
 - bosh-director/**/*
-- bosh_common/**/*
+- bosh-common/**/*
 - vendor/cache/*.gem
 - vendor/cache/extensions/**

src/Gemfile

@@ -3,7 +3,7 @@ source 'https://rubygems.org'
 gem 'bosh-director', path: 'bosh-director'
 gem 'bosh-monitor', path: 'bosh-monitor'
 gem 'bosh-nats-sync', path: 'bosh-nats-sync'
-gem 'bosh_common', path: 'bosh_common'
+gem 'bosh-common', path: 'bosh-common'
 
 gem 'mysql2'
 gem 'pg'

src/Gemfile.lock

@@ -1,10 +1,15 @@
+PATH
+  remote: bosh-common
+  specs:
+    bosh-common (0.0.0)
+
 PATH
   remote: bosh-director
   specs:
     bosh-director (0.0.0)
       activesupport
       bcrypt
-      bosh_common (~> 0.0.0)
+      bosh-common (~> 0.0.0)
       bosh_cpi
       cf-uaa-lib
       json
@@ -58,11 +63,6 @@ PATH
       openssl
       rufus-scheduler
 
-PATH
-  remote: bosh_common
-  specs:
-    bosh_common (0.0.0)
-
 GEM
   remote: https://rubygems.org/
   specs:
@@ -333,10 +333,10 @@ PLATFORMS
 
 DEPENDENCIES
   async-rspec
+  bosh-common!
   bosh-director!
   bosh-monitor!
   bosh-nats-sync!
-  bosh_common!
   bundle-audit
   factory_bot
   fakefs

src/bosh_common/.gitignore src/bosh-common/.gitignore

@@ -2,7 +2,7 @@
 require File.expand_path('../lib/bosh/common/version', __FILE__)
 
 Gem::Specification.new do |spec|
-  spec.name         = 'bosh_common'
+  spec.name         = 'bosh-common'
   spec.version      = Bosh::Common::VERSION
   spec.platform     = Gem::Platform::RUBY
   spec.summary      = 'BOSH common'

src/bosh_common/bosh_common.gemspec src/bosh-common/bosh-common.gemspec

@@ -3,7 +3,7 @@
 
 module Bosh::Common
   describe 'gem' do
-    let(:name) { 'bosh_common' }
+    let(:name) { 'bosh-common' }
     let(:spec) { Gem::Specification.load "#{name}.gemspec" }
 
     it 'validates' do

src/bosh_common/lib/bosh/common.rb src/bosh-common/lib/bosh/common.rb

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
   ]
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'bosh_common',   "~>#{Bosh::Director::VERSION}"
+  spec.add_dependency 'bosh-common',   "~>#{Bosh::Director::VERSION}"
 
   spec.add_dependency 'activesupport'
   spec.add_dependency 'bcrypt'