Skip to content

Commit e75e781

Browse files
authored
Merge pull request #321 from ImMin5/master
Update query filters to use schedule.state and include workspace…
2 parents 728b8c9 + 255b3b0 commit e75e781

File tree

4 files changed

+36
-28
lines changed

4 files changed

+36
-28
lines changed

src/spaceone/cost_analysis/manager/cost_manager.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,12 @@ def _add_hint_to_query(query: dict) -> dict:
633633

634634
if key == "workspace_id" and operator in ["eq", "not", "in", "not_in"]:
635635
workspace_id_exist = True
636-
elif key in ["project_id", "user_projects"] and operator in ["eq", "not", "in", "not_in"]:
636+
elif key in ["project_id", "user_projects"] and operator in [
637+
"eq",
638+
"not",
639+
"in",
640+
"not_in",
641+
]:
637642
project_id_exist = True
638643

639644
if workspace_id_exist and project_id_exist:

src/spaceone/cost_analysis/manager/data_source_rule_manager.py

+7-7
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ def _get_project(
246246

247247
query = {
248248
"filter": [{"k": target_key, "v": target_value, "o": "eq"}],
249-
"only": ["project_id"],
249+
"only": ["project_id", "workspace_id"],
250250
}
251251
if workspace_id:
252252
query["filter"].append({"k": "workspace_id", "v": workspace_id, "o": "eq"})
@@ -260,9 +260,9 @@ def _get_project(
260260
if total_count > 0:
261261
project_info = results[0]
262262

263-
self._project_info[
264-
f"project:{domain_id}:{target_key}:{target_value}"
265-
] = project_info
263+
self._project_info[f"project:{domain_id}:{target_key}:{target_value}"] = (
264+
project_info
265+
)
266266
return project_info
267267

268268
def _get_workspace(
@@ -287,9 +287,9 @@ def _get_workspace(
287287
if total_count > 0:
288288
workspace_info = results[0]
289289

290-
self._workspace_info[
291-
f"workspace:{domain_id}:{target_key}:{target_value}"
292-
] = workspace_info
290+
self._workspace_info[f"workspace:{domain_id}:{target_key}:{target_value}"] = (
291+
workspace_info
292+
)
293293
return workspace_info
294294

295295
def _change_cost_data_by_rule(

src/spaceone/cost_analysis/service/cost_report_data_service.py

+20-19
Original file line numberDiff line numberDiff line change
@@ -226,25 +226,25 @@ def _aggregate_monthly_cost_report_data(
226226
aggregated_cost_report_data.get("data_source_id")
227227
)
228228

229-
aggregated_cost_report_data[
230-
"cost"
231-
] = CostReportManager.get_exchange_currency(
232-
ag_cost, ag_cost_report_currency, self.currency_map
229+
aggregated_cost_report_data["cost"] = (
230+
CostReportManager.get_exchange_currency(
231+
ag_cost, ag_cost_report_currency, self.currency_map
232+
)
233233
)
234234
aggregated_cost_report_data["currency"] = currency
235235
aggregated_cost_report_data["issue_date"] = issue_date
236236
aggregated_cost_report_data["report_month"] = report_month
237-
aggregated_cost_report_data[
238-
"report_year"
239-
] = aggregated_cost_report_data.pop("billed_year")
237+
aggregated_cost_report_data["report_year"] = (
238+
aggregated_cost_report_data.pop("billed_year")
239+
)
240240
aggregated_cost_report_data["workspace_name"] = workspace_name
241241
aggregated_cost_report_data["project_name"] = project_name_map.get(
242242
aggregated_cost_report_data["project_id"], "Unknown"
243243
)
244-
aggregated_cost_report_data[
245-
"service_account_name"
246-
] = service_account_name_map.get(
247-
aggregated_cost_report_data["service_account_id"], "Unknown"
244+
aggregated_cost_report_data["service_account_name"] = (
245+
service_account_name_map.get(
246+
aggregated_cost_report_data["service_account_id"], "Unknown"
247+
)
248248
)
249249

250250
aggregated_cost_report_data["cost_report_config_id"] = cost_report_config_id
@@ -298,9 +298,9 @@ def _get_service_account_name_map(self, workspace_id: str, domain_id: str) -> di
298298
domain_id,
299299
)
300300
for service_account in service_accounts.get("results", []):
301-
service_account_name_map[
302-
service_account["service_account_id"]
303-
] = service_account["name"]
301+
service_account_name_map[service_account["service_account_id"]] = (
302+
service_account["name"]
303+
)
304304
return service_account_name_map
305305

306306
@staticmethod
@@ -323,16 +323,17 @@ def _get_data_source_currency_map(
323323
)
324324

325325
if data_source_state := data_source_filter.get("state", "ENABLED"):
326-
query["filter"].append({"k": "state", "v": data_source_state, "o": "eq"})
327-
326+
query["filter"].append(
327+
{"k": "schedule.state", "v": data_source_state, "o": "eq"}
328+
)
328329
_LOGGER.debug(f"[get_data_source_currency_map] query: {query}")
329330

330331
data_source_vos, total_count = data_source_mgr.list_data_sources(query)
331332
data_source_ids = []
332333
for data_source_vo in data_source_vos:
333-
data_source_currency_map[
334-
data_source_vo.data_source_id
335-
] = data_source_vo.plugin_info["metadata"]["currency"]
334+
data_source_currency_map[data_source_vo.data_source_id] = (
335+
data_source_vo.plugin_info["metadata"]["currency"]
336+
)
336337
data_source_ids.append(data_source_vo.data_source_id)
337338

338339
return data_source_currency_map, data_source_ids

src/spaceone/cost_analysis/service/cost_report_serivce.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,9 @@ def _get_data_source_currency_map(
687687
)
688688

689689
if data_source_state := data_source_filter.get("state", "ENABLED"):
690-
query["filter"].append({"k": "state", "v": data_source_state, "o": "eq"})
690+
query["filter"].append(
691+
{"k": "schedule.state", "v": data_source_state, "o": "eq"}
692+
)
691693

692694
_LOGGER.debug(f"[get_data_source_currency_map] query: {query}")
693695

0 commit comments

Comments
 (0)