Other: The text alignment toolbar should have a proper aria-label a…

…ttribute (see ckeditor/ckeditor5#1404).
ckeditor · Aug 13, 2019 · 3ed81de · 3ed81de
2 parents 599ea01 + cfc1e78
commit 3ed81de
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/lang/contexts.json b/lang/contexts.json
@@ -3,5 +3,6 @@
 	"Align right": "Toolbar button tooltip for aligning the text to the right.",
 	"Align center": "Toolbar button tooltip for aligning the text to center.",
 	"Justify": "Toolbar button tooltip for making the text justified.",
-	"Text alignment": "Dropdown button tooltip for the text alignment feature."
+	"Text alignment": "Dropdown button tooltip for the text alignment feature.",
+	"Text alignment toolbar": "Label used by assistive technologies describing the text alignment feature toolbar."
 }
diff --git a/src/alignmentui.js b/src/alignmentui.js
@@ -93,6 +93,7 @@ export default class AlignmentUI extends Plugin {
 			} );
 
 			dropdownView.toolbarView.isVertical = true;
+			dropdownView.toolbarView.ariaLabel = t( 'Text alignment toolbar' );
 
 			dropdownView.extendTemplate( {
 				attributes: {

diff --git a/tests/alignmentui.js b/tests/alignmentui.js
@@ -241,10 +241,11 @@ describe( 'Alignment UI', () => {
 			expect( dropdown.element.classList.contains( 'ck-alignment-dropdown' ) ).to.be.true;
 		} );
 
-		it( '#toolbarView has the base properties', () => {
+		it( '#toolbarView has the basic properties', () => {
 			const toolbarView = dropdown.toolbarView;
 
 			expect( toolbarView ).to.have.property( 'isVertical', true );
+			expect( toolbarView ).to.have.property( 'ariaLabel', 'Text alignment toolbar' );
 		} );
 
 		it( 'should hold defined buttons', () => {