Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links within Campaign and Slider components do not show external icons #92

Closed
richardgaunt opened this issue Mar 2, 2024 · 4 comments · Fixed by #93
Closed

Links within Campaign and Slider components do not show external icons #92

richardgaunt opened this issue Mar 2, 2024 · 4 comments · Fixed by #93
Assignees
@AlexSkrypnyk
Labels
PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) State: Done The issue is complete and waiting for a release
Milestone
1.7

Comments

@richardgaunt
Copy link
Collaborator

See: https://github.com/civictheme/uikit/blob/main/components/03-organisms/campaign/campaign.twig#L100

There should be a is_external property being passed to button.twig but there is not.
The drupal paragraph preprocess passes is_external which obviously isn't being utilised at the moment.
@richardgaunt
Copy link
Collaborator Author

PR here: #93

@fionamorrison23 fionamorrison23 added this to the 1.7 milestone Mar 6, 2024
@fionamorrison23 fionamorrison23 moved this to In Progress in UI Kit Mar 6, 2024
@fionamorrison23
Copy link
Collaborator

@AlexSkrypnyk please review. Thanks.

@AlexSkrypnyk AlexSkrypnyk added the PR: Ready for test Pull request is ready for manual testing label Mar 7, 2024
@AlexSkrypnyk
Copy link
Contributor

@sonamchaturvedi28
When testing, please note that it is not possible to control whether randomly generated links are external or not - please use the slider below to add links and some of them will be external.

Window_and_Organisms___Campaign_-_Campaign_⋅_Storybook

@AlexSkrypnyk AlexSkrypnyk changed the title Campaign component does not pass the is_external property for links to button.twig Links within Campaign and Slider components do not show external icons Mar 7, 2024
@sonamchaturvedi28
Copy link

Test links: https://civictheme-uikit.netlify.app/?path=/story/organisms-slider--slider and https://civictheme-uikit.netlify.app/?path=/story/organisms-campaign--campaign
Test Status: PASS
Test Result:

  • External links within Campaign and Slider components now show external icons
Screenshot 2024-03-11 at 3 00 00 PM image

@sonamchaturvedi28 sonamchaturvedi28 added PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) and removed PR: Ready for test Pull request is ready for manual testing labels Mar 11, 2024
@AlexSkrypnyk AlexSkrypnyk mentioned this issue Mar 11, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in UI Kit Mar 11, 2024
@AlexSkrypnyk AlexSkrypnyk added the State: Done The issue is complete and waiting for a release label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexSkrypnyk AlexSkrypnyk

Labels
PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) State: Done The issue is complete and waiting for a release
Projects
UI Kit
Status: Done
Milestone
1.7
4 participants
@AlexSkrypnyk @sonamchaturvedi28 @richardgaunt @fionamorrison23