Skip to content

Commit fa980d2

Browse files
authored
fix: wrong default write batch size for run_tsbs (apache#845)
* fix: wrong default write batch size for run_tsbs * fix: clippy error
1 parent 7796cb6 commit fa980d2

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

analytic_engine/src/table/data.rs

+1-4
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,7 @@ fn compute_mutable_limit(
181181
write_buffer_size: u32,
182182
mutable_limit_write_buffer_size_ratio: f32,
183183
) -> u32 {
184-
assert!(
185-
mutable_limit_write_buffer_size_ratio >= 0.0
186-
&& mutable_limit_write_buffer_size_ratio <= 1.0
187-
);
184+
assert!((0.0..=1.0).contains(&mutable_limit_write_buffer_size_ratio));
188185

189186
let limit = write_buffer_size as f32 * mutable_limit_write_buffer_size_ratio;
190187
// This is safe because the limit won't be larger than the write_buffer_size.

scripts/run-tsbs.sh

+2-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export LOG_DIR=${LOG_DIR:-${CURR_DIR}/logs}
1717
export CERESDB_ADDR=${CERESDB_ADDR:-127.0.0.1:8831}
1818
export CERESDB_PID_FILE=${CURR_DIR}/ceresdb-server.pid
1919
export WRITE_WORKER_NUM=${WRITE_WORKER_NUM:-36}
20-
export WRITE_BATCH_SIZE=${WRITE_BATCH_SIZE:500}
20+
export WRITE_BATCH_SIZE=${WRITE_BATCH_SIZE:-500}
2121
# Where generated data stored
2222
export DATA_FILE=${DATA_FILE:-data.out}
2323
# How many values in host tag
@@ -87,8 +87,7 @@ fi
8787

8888

8989
# Write data to ceresdb
90-
./tsbs_load_ceresdb --ceresdb-addr=${CERESDB_ADDR} --file ${DATA_FILE} --batch-size ${WRITE_BATH_SIZE} --workers ${WRITE_WORKER_NUM} | tee ${LOG_DIR}/write.log
91-
90+
./tsbs_load_ceresdb --ceresdb-addr=${CERESDB_ADDR} --file ${DATA_FILE} --batch-size ${WRITE_BATCH_SIZE} --workers ${WRITE_WORKER_NUM} | tee ${LOG_DIR}/write.log
9291

9392
# Generate queries for query
9493
./scripts/generate_queries.sh

0 commit comments

Comments
 (0)