chore: add write batch metrics (apache#827)

jiacai2050 · web-flow · commit b0cdf2efea07 · 2023-04-12T02:42:22.000Z
* chore: add write batch metrics

* fix CI

* fix CR
diff --git a/analytic_engine/src/table/metrics.rs b/analytic_engine/src/table/metrics.rs
@@ -29,9 +29,10 @@ lazy_static! {
     )
     .unwrap();
 
-    static ref TABLE_WRITE_ROWS_COUNTER: IntCounter = register_int_counter!(
-        "table_write_rows_counter",
-        "Number of rows wrote to table"
+    static ref TABLE_WRITE_BATCH_HISTGRAM: Histogram = register_histogram!(
+        "table_write_batch_size",
+        "Histgram of write batch size",
+        vec![10.0, 50.0, 100.0, 500.0, 1000.0, 5000.0]
     )
     .unwrap();
 
@@ -164,7 +165,7 @@ impl Metrics {
 
     #[inline]
     pub fn on_write_request_done(&self, num_rows: usize) {
-        TABLE_WRITE_ROWS_COUNTER.inc_by(num_rows as u64);
+        TABLE_WRITE_BATCH_HISTGRAM.observe(num_rows as f64);
     }
 
     #[inline]

Original file line number	Diff line number	Diff line change
`@@ -29,9 +29,10 @@ lazy_static! {`
`29`	`29`	`)`
`30`	`30`	`.unwrap();`
`31`	`31`
`32`		`- static ref TABLE_WRITE_ROWS_COUNTER: IntCounter = register_int_counter!(`
`33`		`- "table_write_rows_counter",`
`34`		`- "Number of rows wrote to table"`
	`32`	`+ static ref TABLE_WRITE_BATCH_HISTGRAM: Histogram = register_histogram!(`
	`33`	`+ "table_write_batch_size",`
	`34`	`+ "Histgram of write batch size",`
	`35`	`+ vec![10.0, 50.0, 100.0, 500.0, 1000.0, 5000.0]`
`35`	`36`	`)`
`36`	`37`	`.unwrap();`
`37`	`38`
`@@ -164,7 +165,7 @@ impl Metrics {`
`164`	`165`
`165`	`166`	`#[inline]`
`166`	`167`	`pub fn on_write_request_done(&self, num_rows: usize) {`
`167`		`- TABLE_WRITE_ROWS_COUNTER.inc_by(num_rows as u64);`
	`168`	`+ TABLE_WRITE_BATCH_HISTGRAM.observe(num_rows as f64);`
`168`	`169`	`}`
`169`	`170`
`170`	`171`	`#[inline]`