Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit testing coverage #70

Open
chris-greening opened this issue Mar 29, 2023 · 2 comments
Open

Increase unit testing coverage #70

chris-greening opened this issue Mar 29, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chris-greening
Copy link
Owner

Is your feature request related to a problem? Please describe.
Increase relevant unit test coverage using pytest. Existing tests can be found in tests/. Whether you write one test or a hundred tests every bit helps! Please feel free to comment below if you're interested

Some relevant notes that can point you in the right direction:
Currently the library has two "general" shapes Hypotrochoid and Epitrochoid and two "special" shapes Hypocycloid and Epicycloid (which inherit from the general shapes and define some special behavior).

Because of how the special behavior is handled we temporarily have a semi-awkward set of tests defined as methods in classes _TestGeneral and _TestSpecial where _TestGeneral is intended for testing Hypotrochoid and Epitrochoid and _TestSpecial is for testing Hypocycloid and Epicycloid

@chris-greening chris-greening added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 29, 2023
@chris-greening chris-greening pinned this issue Mar 29, 2023
@valzes
Copy link
Contributor

valzes commented Apr 22, 2023

I would like to contribute to improve the code coverage.

@chris-greening
Copy link
Owner Author

Heyo @valzes apologies for late reply - that would be fantastic!! Let me know if you have any questions 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants