Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links that have styleAttributes don't add the URL attribute #8

Open
diogot opened this issue Jul 17, 2020 · 0 comments · May be fixed by #9
Open

Links that have styleAttributes don't add the URL attribute #8

diogot opened this issue Jul 17, 2020 · 0 comments · May be fixed by #9

Comments

@diogot
Copy link

diogot commented Jul 17, 2020

As this snippet shows if there is a styleAttributes for links the url attribute is ignored.

MarkdownAttributedString/NSAttributedString+Markdown.m

Lines 474 to 479 in 750e8d5

if (styleAttributes[MarkdownStyleLink]) {
replacementAttributes = styleAttributes[MarkdownStyleLink];
}
else {
replacementAttributes = @{ NSLinkAttributeName: URL };
}

I need to customise the link color and keep them tappable.
I'll send a PR soon.
@diogot diogot linked a pull request Jul 17, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep the URL attribute if there is custom style diogot/MarkdownAttributedString
1 participant
@diogot