Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC-2309 #310

Closed
Vectorized opened this issue Jun 1, 2022 · 3 comments · Fixed by #311
Closed

ERC-2309 #310

Vectorized opened this issue Jun 1, 2022 · 3 comments · Fixed by #311

Comments

@Vectorized
Copy link
Collaborator

Vectorized commented Jun 1, 2022 •
edited
Loading

https://eips.ethereum.org/EIPS/eip-2309
@Vectorized Vectorized changed the title EIP-2309 ERC-2309 Jun 4, 2022
@Vectorized Vectorized linked a pull request Jun 4, 2022 that will close this issue
Add ERC-2309 support for mints during contract creation #311
Merged
1 task
@TimTinkers
Copy link

TimTinkers commented Jul 30, 2022 •
edited
Loading

Hi @Vectorized. I'm building an NFT indexing service and am currently concerned with having to truncate ConsecutiveTransfer ranges to prevent denial of service on operations using EIP-2309 with huge ranges. I see here that Chiru Labs has set a range limit of 5000 on the size of a ConsecutiveTransfer. From my denial-of-service perspective, this is obviously a good thing. Unfortunately no such limit is mandated by the EIP-2309 standard; can you help me understand why you chose 5,000 for this implementation? Thanks!

This was referenced Jul 30, 2022
Closed
Closed
@Vectorized
Copy link
Collaborator Author

Vectorized commented Jul 30, 2022 •
edited
Loading

5000 is the limit OpenSea supports, determined empirically. And it’s a reasonable number to prevent overflows on ERC721A. @TimTinkers

@TimTinkers
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ERC-2309 support for mints during contract creation Vectorized/ERC721A
2 participants
@TimTinkers @Vectorized