Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-edit and aux text after commit_text () #123

Merged
merged 1 commit into from
Sep 24, 2017

Conversation

hiunnhue
Copy link
Collaborator

@hiunnhue hiunnhue commented Sep 23, 2017

預編區額滿、自動送出的時候,預編區會看起來像是在閃爍。仔細觀察可發現,在按下按鍵、自動送出的那瞬間,預邊區的文字會消失,然後才又出現,這個現象在 chromium 的網址列特別明顯。

commit_text(self) 往前挪,這個現象就消失了。

This prevent pre-edit text from flashing when auto-commit.
@definite definite self-requested a review September 24, 2017 23:58
Copy link
Member

@definite definite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@definite definite merged commit e946b46 into chewing:master Sep 24, 2017
@hiunnhue hiunnhue deleted the update_commit branch September 26, 2017 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants