Update property list (language bar) #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains the following modifications: 1. Fix: the property list (language bar) does not update when toggling Chi/Eng Mode or Fullwidth/Halfwidth Shape via the systray icon. 2. Add a setup button to the ibus indicator (and the language bar), so that users can open the setup window more quickly. In order to have consistent style with other buttons on bar, use property symbol instead of icon. 3. Make the naming of prop_name more consistent: "chiEng_prop", "alnumSize_prop", and "setup_prop". 4. Update property labels and tooltips.
|
修改後的語言工具列：
修改後的 ibus indicator ：
|
|
Thanks for your contribution! |
|
Thanks for reviewing and merging ! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the following modifications:
Fix: the property list (language bar) does not update when
toggling Chi/Eng Mode or Fullwidth/Halfwidth Shape via the
systray icon.
Add a setup button to the ibus indicator (and the language
bar), so that users can open the setup window more quickly.
In order to have consistent style with other buttons on
bar, use property symbol instead of icon.
Make the naming of prop_name more consistent:
"chiEng_prop", "alnumSize_prop", and "setup_prop".
Update property labels and tooltips.