This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Rubocop should install to chefdk/bin #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrajaktaPurohit
changed the title
PrajaktaPurohit
force-pushed
the
intermediate/cd/FLOW-369
branch
from
7bd9998 to
05a1bbb
Compare
PrajaktaPurohit
force-pushed
the
intermediate/cd/FLOW-369
branch
from
05a1bbb to
51bface
Compare
added 2 commits
May 26, 2016 10:34
- Create an :overrideable option for 'gem', to give our Rubocop precedence below any
that come after (but not any that come before).
- BuildChefDKAppbundle requires that gems have a Gemfile that includes their gemspec;
Rubocop doesn't ship either one, so write them out for any gem that's missing them.
…stead of embedded_bin("rubocop").
mwrock
force-pushed
the
intermediate/cd/FLOW-369
branch
from
51bface to
8c6e0cf
Compare
mwrock
force-pushed
the
intermediate/cd/FLOW-369
branch
from
c03004c to
1d50026
Compare
|
This succeeded on my local omnibus windows builder. I also installed the built package and ensured rubocop truly is in chefdk/bin and works. |
mwrock
force-pushed
the
intermediate/cd/FLOW-369
branch
from
7a3c970 to
b3a0cf2
Compare
|
this also produced a green jenkins build/test |
mwrock
force-pushed
the
intermediate/cd/FLOW-369
branch
from
b3a0cf2 to
4b63213
Compare
1 task
|
Awesome catch! @mwrock +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Only using this branch as a test branch - if that passes, we can merge in the original PR)