Skip to content
This repository was archived by the owner on Jul 14, 2021. It is now read-only.

Fix typo in warning.txt. Obvious fix. #567

Merged
merged 1 commit into from
Oct 19, 2015

Conversation

TonyLovesDevOps
Copy link

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

danielsdeleo added a commit that referenced this pull request Oct 19, 2015
Fix typo in warning.txt. Obvious fix.
@danielsdeleo danielsdeleo merged commit 6ad0ee4 into chef-boneyard:master Oct 19, 2015
@philoserf
Copy link
Contributor

@TonyFlint The 'obvious fix' may need to follow the first line in the commit message.

Whenever you invoke the “obvious fix” rule, please say so in your commit message:

------------------------------------------------------------------------
commit 370adb3f82d55d912b0cf9c1d1e99b132a8ed3b5
Author: danielsdeleo <dan@chef.io>
Date:   Wed Sep 18 11:44:40 2013 -0700

  Fix typo in config file docs.

  Obvious fix.

--------------------------------------------------------------------–--

@danielsdeleo
Copy link
Contributor

@philoserf that's the merge commit github made for me since I used the green button. @TonyFlint did put "obvious fix" in the first line of the commit message.

@philoserf
Copy link
Contributor

@danielsdeleo I read his commit message too. Both had obvious fix on the first/only line of the commit message. It wasn't clear to me if curry bot wanted it on another line a.l.a. some commit style pedantic.

@danielsdeleo
Copy link
Contributor

@philoserf I don't think curry knows about the obvious fix rule, but I will double check that.

@danielsdeleo
Copy link
Contributor

Confirmed that Curry doesn't do any checking for the obvious fix rule, either in the commit message to see if the author invoked it, or in the content, to see if it could apply.

ksubrama pushed a commit that referenced this pull request Jan 11, 2016
Pin again for 12.6.0 release
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants