Allow setting CHEFDK_HOME #412
Conversation
|
|
||
| require 'chef/http/simple' | ||
|
|
||
| # Configure CookbookOmnifetch's dependency injection settings to use our classes and config. | ||
| CookbookOmnifetch.configure do |c| | ||
| c.cache_path = File.expand_path('~/.chefdk/cache') | ||
| c.storage_path = Pathname.new(File.expand_path('~/.chefdk/cache/cookbooks')) | ||
| helpers = Class.new do |
There was a problem hiding this comment.
If all of the helpers are stateless functions, you could just add extend self over there and then you can call all the methods as module functions.
There was a problem hiding this comment.
They memoize :(
it broke my tests, and had to change it this way.
OTOH, we could just not do the whole ||= thing
There was a problem hiding this comment.
If the output would only reasonably change during tests, then we could have an @api private method like reset!.
| if chefdk_home_set | ||
| ENV['CHEFDK_HOME'] | ||
| else | ||
| old_home = File.join(Gem.user_home, '.chefdk') |
There was a problem hiding this comment.
I don't think backcompat is strictly require if this only affects Policyfiles. We can just document it in the release announcement.
There was a problem hiding this comment.
Fair enough. It will actually do the right thing if people use chefdk through the omnibus package. I'll remove the backcompat stuff here.
|
👍 modulo the nitpicks. BTW, is the local app data directory something all windows admins will know about? Maybe we should have a |
|
|
|
👍 |
Moving fix for #420 to master
Related omnibus changes: chef-boneyard/omnibus-chef#406