Add support for a Windows environment without true/false

[btm]

We don't always have true.exe / false.exe on Windows, especially
if we don't have the embedded bin directory from the omnibus package
in our path. This patch uses powershell + exit to simulate the same thing.

Fixes a number of failing tests. /cc @jdmundrawala

[jaym]

👍

[btm]

@opscode/client-engineers ?

[danielsdeleo]

Do we really need powershell to have a command that exits 0 or 1 on windows?

[btm]

We could do the same thing with cmd.exe, which is probably a bit more lightweight. We should reliably have both cmd and powershell on a system already, whereas the existing code requires us to either install a tool or include embedded\bin in the PATH (which contains a false/true) which we keep flipping around on. Wherever we stay with the PATH, it's nice if we don't need it.

[jaym]

@btm does can we use ruby?
ruby -e exit 0 or ruby -e exit 1?

[tyler-ball]

@jdmundrawala ruby -e exit 1 didn't work for me in IRB, but ruby -e abort did.

[danielsdeleo]

@tyler-ball it would have to be ruby -e 'exit 1' with the quotes.

[tyler-ball]

@danielsdeleo 👍 yup, that worked

[btm]

Ruby was surprisingly fast. I expected it to suck on windows. It's 2-3 times faster than loading powershell:

$ time ruby -e 'exit 1'

real    0m0.071s
user    0m0.000s
sys     0m0.015s

$ time powershell 'exit 1'

real    0m0.253s
user    0m0.015s
sys     0m0.000s

[btm]

Although cmd.exe appears to be slightly faster (once I got the right quotes)...

$ time cmd.exe /c "exit 50"

real    0m0.026s
user    0m0.015s
sys     0m0.000s

[jaym]

I think the benefit of using ruby is that we only have to maintain 1 code
path.

On Wed, Nov 19, 2014 at 8:55 AM, Bryan McLellan notifications@github.com
wrote:

Although cmd.exe appears to be slightly faster (once I got the right
quotes)...

$ time cmd.exe /c "exit 50"

real 0m0.026s
user 0m0.015s
sys 0m0.000s

—
Reply to this email directly or view it on GitHub
#240 (comment).

[danielsdeleo]

If exit 0 and exit 1 work correctly on windows, then we can use that with no if statements.

[jaym]

[danielsdeleo]

👍