This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Pulled in fix for joining paths on windows #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +70,7 @@ def run_command | |||
|
|
|||
| let(:omnibus_bin_dir) { "/foo/bin" } | |||
|
|
|||
| let(:expected_PATH) { "#{omnibus_bin_dir}:#{user_bin_dir}:#{omnibus_embedded_bin_dir}:#{ENV['PATH']}" } | |||
| let(:expected_PATH) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV['PATH']].join(File::PATH_SEPARATOR) } | |||
|
|
|||
| let(:expected_GEM_ROOT) { Gem.default_dir.inspect } | |||
|
|
|||
There was a problem hiding this comment.
On line 92 (it won't let me comment there), can you add the expected error? .to raise_error(SomeError, "message")
There was a problem hiding this comment.
I think the person who wrote it explicitly didn't care:
# XXX: this isn't a test we just need to swallow the exception
|
👍 |
|
👍 also ran the tests locally. I had some unrelated test failures. I'm going to merge this to clean up some confusion where a few of us are working on the same code now. |
btm
added a commit
that referenced
this pull request
Nov 13, 2014
Pulled in fix for joining paths on windows
danielsdeleo
added a commit
that referenced
this pull request
Nov 13, 2014
jaym
added a commit
to jaym/chef-dk
that referenced
this pull request
Nov 20, 2014
* canonical/master: Show the path checked on MissingComponentError Add verification of linked scripts on *nix Don't treat git local remotes as "remote" Update CHANGELOG for PR chef-boneyard#232 Bump version and update changelog for 0.3.5 Added comment about <> path separator in spec Used unbiased stub for path separator where it made sense stub was in the wrong place Tests pass for path separator change missing , fix path joining for windows Added comment for with_file Factor out File.open(path, "wb+", block) into method Emit PATH warnings to stderr instead of stdout Update Changelog for 0.3.4, bump version Bump version and update changelog for 0.3.3 Replaced w+ with wb+ to make comparisons on windows happy policyfile store_config_spec passes on windows Cookbook profiler git_specs pass on windows. cli_specs pass on Windows
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Add EL7 support to x86_64 build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#180
Pulled in Lamont's fix and updated the specs.
cc @opscode/client-engineers @bwmeier