This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Add Dist file to control the product / CLI names #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sure this is going to fail, but I wanted to get it up and I did it on a long flight. |
mjingle
reviewed
Jun 24, 2019
mjingle
reviewed
Jun 24, 2019
This is a requirement for the community edition. It also has some very nice benefits internally for Chef Inc. - We get consistent usage of our product names. DK wasn't that bad, but it wasn't great. - We provide a single place we can patch in Workstation to change the name in the UI from Chef DK -> Chef Workstation I also updated a few places were Policyfile wasn't capitalized. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: mjingle <mjingle@users.noreply.github.com>
As MP pointed out this doesn't make sense in a hosted sort of setup. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
dist
branch
3 times, most recently
from
2eadefb to
7c6e057
Compare
I'm not converting these to regexes at the moment. This PR will get the dist part setup, but the work of making the specs pass in a non-chef branded DK will occur later Signed-off-by: Tim Smith <tsmith@chef.io>
robbkidd
reviewed
Jun 25, 2019
robbkidd
reviewed
Jun 25, 2019
robbkidd
reviewed
Jun 25, 2019
robbkidd
reviewed
Jun 25, 2019
robbkidd
reviewed
Jun 25, 2019
Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: Robb Kidd <robb@thekidds.org>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: Robb Kidd <robb@thekidds.org>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: Robb Kidd <robb@thekidds.org>
robbkidd
approved these changes
Jun 25, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a requirement for the community edition. It also has some very nice benefits internally for Chef Inc.
- We get consistent usage of our product names. DK wasn't that bad, but it wasn't great.
- We provide a single place we can patch in Workstation to change the name in the UI from Chef DK -> Chef Workstation
I also updated a few places were Policyfile wasn't capitalized.
Signed-off-by: Tim Smith tsmith@chef.io