Skip to content
This repository was archived by the owner on Jul 14, 2021. It is now read-only.

Improve chef --version command #2143

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Improve chef --version command #2143

merged 3 commits into from
Jun 20, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 20, 2019

  1. Remove delivery and berkshelf from the output as we care less about these tools
  2. Include cookstyle and foodcritic as we do care what versions we're running
  3. Output the branding name not the CLI name

Old output:

Chef Development Kit Version: 4.0.75
chef-client version: 15.0.300
delivery version: 0.0.52 (9d07501a3b347cc687c902319d23dc32dd5fa621)
berks version: 7.0.8
kitchen version: 2.2.5
inspec version: 4.6.4

New output:

Chef Development Kit Version: 4.0.75

Chef Infra Client version: 15.0.300
Test Kitchen version: 2.2.5
Foodcritic version: 16.0.0
Cookstyle version: 4.0.0
InSpec version: 4.6.4

Signed-off-by: Tim Smith tsmith@chef.io

1) Remove delivery and berkshelf from the output as we care less about these tools
2) Include cookstyle and foodcritic as we do care what versions we're running
3) Output the branding name not the CLI name

Old output:
```
Chef Development Kit Version: 4.0.75
chef-client version: 15.0.300
delivery version: 0.0.52 (9d07501a3b347cc687c902319d23dc32dd5fa621)
berks version: 7.0.8
kitchen version: 2.2.5
inspec version: 4.6.4
```

New output:
```
Chef Development Kit Version: 4.0.75

Chef Infra Client version: 15.0.300
Test Kitchen version: 2.2.5
Foodcritic version: 16.0.0
Cookstyle version: 4.0.0
InSpec version: 4.6.4
```

Signed-off-by: Tim Smith <tsmith@chef.io>
Copy link

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

tas50 added 2 commits June 20, 2019 15:47
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 merged commit d2aa18b into master Jun 20, 2019
@chef-ci chef-ci deleted the better_version branch June 20, 2019 16:43
@lock
Copy link

lock bot commented Aug 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants