This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Fix habitat packages that didn't build #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
requested review from
marcparadise,
jonsmorrow,
lamont-granquist and
robbkidd
robbkidd
reviewed
Jun 12, 2019
marcparadise
approved these changes
Jun 17, 2019
tas50
changed the title
1) we don't use iconv in chef/chef so why use it here 2) we needed pkg-config, which is recommended on the nokogiri site Signed-off-by: Tim Smith <tsmith@chef.io>
This looks weird, but makes it so we only have to change what Ruby the package depends on once. Also, should use $(pkg_path_for ..) function in plans, not a shell out to the $(hab pkg path ..) command. Signed-off-by: Robb Kidd <robb@thekidds.org>
Rub some loops on it to reduce repetition. Signed-off-by: Robb Kidd <robb@thekidds.org>
Speeds up and reduces the size of the build. Signed-off-by: Robb Kidd <robb@thekidds.org>
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Smith tsmith@chef.io