This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Pull in Chef 15.0.293 and Foodcritic 16 #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required moving push jobs client to git, which *may* work. We need to push that gem. Signed-off-by: Tim Smith <tsmith@chef.io>
Gemfile
Outdated
| @@ -101,7 +101,7 @@ group(:omnibus_package) do | |||
| gem "chef-sugar" | |||
| gem "mixlib-versioning" | |||
| gem "artifactory" | |||
| gem "opscode-pushy-client", ">= 2.1" | |||
| gem "opscode-pushy-client", git: "https://github.com/chef/opscode-pushy-client.git", branch: "master" | |||
There was a problem hiding this comment.
that'll almost certainly break appbundling
There was a problem hiding this comment.
(actually i should stop saying that -- bundle install won't install it correctly into the gem library first)
There was a problem hiding this comment.
Switched to the pre gem so we're good to go now
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
We used to dep on this in chef, but it turned out we weren't using it. It can be removed here as well. Signed-off-by: Tim Smith <tsmith@chef.io>
jaymalasinha
approved these changes
May 14, 2019
lamont-granquist
approved these changes
May 14, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required moving push jobs client to git, which may work. We need to push that gem.
Signed-off-by: Tim Smith tsmith@chef.io