This repository was archived by the owner on Jul 14, 2021. It is now read-only.
[SHACK-304] Add Chef Apply as a gem dependency #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-ball
force-pushed
the
SHACK-304/chef_apply_dep
branch
2 times, most recently
from
518ce56 to
0c87d84
Compare
tas50
approved these changes
Jul 27, 2018
tyler-ball
force-pushed
the
SHACK-304/chef_apply_dep
branch
2 times, most recently
from
45842fb to
a07d092
Compare
cheeseplus
approved these changes
Jul 31, 2018
lamont-granquist
approved these changes
Jul 31, 2018
tyler-ball
force-pushed
the
SHACK-304/chef_apply_dep
branch
2 times, most recently
from
2cd7161 to
ab738c0
Compare
ChefDK holds all the logic for the massive dependency resolution task. Because of this we have to include Chef Apply as a gem dependency, even though we only want to expose it via Chef Workstation and not Chef Apply. That is why we do not appbundle it here but do appbundle it in Chef Workstation. As we move the dependency solving logic out of the ChefDK (per chef-boneyard/chef-rfc#308) and seperate out components (like policyfile and the 'chef' binary) we will eventually not need this dependency here. But until that day... Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
SHACK-304/chef_apply_dep
branch
from
ab738c0 to
090cebb
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChefDK holds all the logic for the massive dependency resolution task.
Because of this we have to include Chef Apply as a gem dependency, even
though we only want to expose it via Chef Workstation and not Chef
Apply. That is why we do not appbundle it here but do appbundle it in
Chef Workstation.
As we move the dependency solving logic out of the ChefDK (per
chef-boneyard/chef-rfc#308) and seperate out components
(like policyfile and the 'chef' binary) we will eventually not need this
dependency here. But until that day...
Issues Resolved
SHACK-304
Check List