This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Validate source options for cookbooks #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @opscode/client-engineers |
| it "sets the source of the cookbook to the git URL" do | ||
| # Chef server isn't yet supported in cookbook-omnifetch (pending /universe endpoint in Chef Server) | ||
| # We have to skip at the example definition level or else we fail in the before block | ||
| skip "sets the source of the cookbook to the git URL" do |
There was a problem hiding this comment.
Maybe? I don't really get the utility of the way pending behaves in rspec 3, but if you think it's super awesome, maybe you can explain why?
There was a problem hiding this comment.
I tried this out, and I found that when you use pending in RSpec 3, the example isn't listed as "pending" in the test report. I prefer that these examples show up as pending in the test report so they're more visible, so I'm gonna stick with skip even though pending is probably what rspec wants me to do.
danielsdeleo
force-pushed
the
validate-policyfile-input
branch
from
95bcd5a to
25e0157
Compare
ksubrama
pushed a commit
that referenced
this pull request
Jan 11, 2016
Disable chef-solo runs on windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid source options in a Policyfile.rb will now be detected as the Policyfile.rb is read and reported as errors. To keep the tests passing I had to disable tests that specified chef-server as a cookbook source, since that isn't implemented in cookbook-omnifetch (and we probably won't implement that until Chef Server adds the /universe endpoint).