Note about latest in readme, fix stray package_name

Author: jtimberman

README.md

@@ -42,7 +42,7 @@ A "chef ingredient" is the core package itself, or products or add-on components
 - `product_name`: (name attribute) The product name. See the [PRODUCT_MATRIX.md](https://github.com/chef-cookbooks/chef-ingredient/blob/master/PRODUCT_MATRIX.md). For example, `chef-server`, `analytics`, `delivery`, `manage`, etc.
 - `ctl_command`: The "ctl" command, e.g., `chef-server-ctl`. This should be automatically detected by the library helper method `chef_ctl_command`, but may need to be specified if something changes, like a new add-on is made available.
 - `options`: Options passed to the `package` resource used for installation.
-- `version`: Package version, e.g., `12.0.4`. Do not use if specifying `package_source`. Default `nil`.
+- `version`: Package version to install. Can be specified in various semver-alike ways: `12.0.4`, `12.0.3-rc.3`, and also `:latest`/`'latest'`. Do not use this property when specifying `package_source`. Default is `:latest`, which will install the latest package from the repository.
 - `package_source`: Full path to a location where the package is located. If present, this file is used for installing the package. Default `nil`.
 - `timeout`: The amount of time (in seconds) to wait to fetch the installer before timing out. Default: default timeout of the Chef package resource - `900` seconds.
 

libraries/chef_ingredient_resource.rb

@@ -36,7 +36,7 @@ class ChefIngredient < Chef::Resource::LWRPBase
 
       # Attributes for package
       attribute :options, kind_of: String
-      attribute :version, kind_of: [String, Symbol], default: '0.0.0'
+      attribute :version, kind_of: [String, Symbol], default: :latest
       attribute :timeout, kind_of: [Integer, String, NilClass], default: nil
     end
   end

libraries/helpers.rb

@@ -26,7 +26,7 @@ def chef_ctl_command(product)
     end
 
     def version_string(vers)
-      return '0.0.0' if vers == :latest || vers == 'latest'
+      return '0.0.0' if vers.to_sym == :latest
       vers
     end
 
@@ -78,12 +78,12 @@ def cleanup_old_repo_config
     end
 
     def ctl_command
-      new_resource.ctl_command || chef_ctl_command(new_resource.package_name)
+      new_resource.ctl_command || chef_ctl_command(new_resource.product_name)
     end
 
     def reconfigure
       ctl_cmd = ctl_command
-      execute "#{new_resource.package_name}-reconfigure" do
+      execute "#{new_resource.product_name}-reconfigure" do
         command "#{ctl_cmd} reconfigure"
       end
     end