fix slack capture

Signed-off-by: Sylvain Hellegouarch <sh@defuze.org>

Author: Lawouach

CHANGELOG.md

@@ -2,16 +2,19 @@
 
 ## [Unreleased][]
 
-[Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.65.0...HEAD
+[Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.65.1...HEAD
 
-## [0.65.0][]
+## [0.65.1][]
 
-[0.65.0]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.64.0...0.65.0
+[0.65.1]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.64.0...0.65.1
 
-### Changed
+## [0.65.1][]
 
-* Remove Reliably bot thread from the history to prevent polutting the timeline
-* Bump dependencies
+[0.65.1]: https://github.com/chaostoolkit-incubator/chaostoolkit-reliably/compare/0.65.0...0.65.1
+
+### Fixed
+
+* Fix thread removal in slack capture
 
 ## [0.64.0][]
 

chaosreliably/controls/capture/slack.py

@@ -43,9 +43,6 @@ def stop_capturing(
         channel, limit, past, include_metadata, secrets
     )
 
-    if history:
-        remove_bot_threads(history)
-
     return history
 
 
@@ -153,6 +150,8 @@ def get_channel_history(
         if user_id not in users:
             users[user_id] = get_user_info(client, user_id)
 
+    remove_bot_threads(threads)
+
     context = {
         "channels": [
             {
@@ -221,12 +220,8 @@ def get_thread_history(
     return messages
 
 
-def remove_bot_threads(history: Dict[str, Any]) -> None:
-    threads = history.get("threads")
-    if not threads:
-        return None
-
-    for t in threads:
+def remove_bot_threads(threads: Dict[str, Any]) -> None:
+    for ts, t in threads.items():
         # flaky heuristic
         bot_id = t.get("bot_id")
         t_type = t.get("type")
@@ -236,7 +231,7 @@ def remove_bot_threads(history: Dict[str, Any]) -> None:
             and t_type == "message"
             and t_text.startswith("Experiment is ")
         ):
-            threads.remove(t)
+            threads.pop(ts, None)
             break
 
     return None