Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading manager tests #52

Merged
merged 3 commits into from
Feb 7, 2018
Merged

Loading manager tests #52

merged 3 commits into from
Feb 7, 2018

Conversation

chanind
Copy link
Owner

@chanind chanind commented Feb 7, 2018

This PR adds some tests and minor tweaks to the loading manager. Specifically, it will throw an error if loading fails and no onLoadCharDataError callback is provided.

@chanind chanind mentioned this pull request Feb 7, 2018
Merged
@chanind chanind merged commit eafab64 into master Feb 7, 2018
@chanind chanind deleted the loading-manager-tests branch February 7, 2018 17:33
@vaab
Copy link
Contributor

vaab commented Feb 11, 2018

Thanks, that's awesome, and was sorely needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chanind @vaab