Fix a nightly test break because of enabling inlining in jitted loop bodies. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rajatd, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
@abchatra can you review this? |
|
@rajatd can you rebase your changes against the latest? There are changes in the javascriptStackwalker which causing rebase issues for me. |
…bodies. There was a bug in getting correct line number for an inlinee in a jitted loop body when doing error.stack. The code wasn't handling inlning in jitted loop bodies. Added support for that.
chakrabot
pushed a commit
that referenced
this pull request
Jan 11, 2016
…itted loop bodies. Merge pull request #5 from rajatd:inliningBreak Fix a nightly test break because of enabling inlining in jitted loop bodies. There was a bug in getting correct line number for an inlinee in a jitted loop body when doing error.stack. The code wasn't handling inlning in jitted loop bodies. Added support for that.
ghost
mentioned this pull request
This was referenced Dec 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a nightly test break because of enabling inlining in jitted loop
bodies.
There was a bug in getting correct line number for an inlinee in a jitted loop
body when doing error.stack. The code wasn't handling inlning in jitted
loop bodies. Added support for that.