Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to disable CFG in win10 #6021

Closed
xuechiyaobai opened this issue Mar 13, 2019 · 4 comments
Closed

How to disable CFG in win10 #6021

xuechiyaobai opened this issue Mar 13, 2019 · 4 comments
Assignees
@LouisLaf

Comments

@xuechiyaobai
Copy link

Recently you add some new code here:c0c3de7#diff-368bbd31c6049b4faa033bbbc971ef0f

But there are some old win10 versions that does not support cfg(my test enviroment is 10.0.14393).
And when I build ch.exe, there is a fatal error that "no such file cfguard.h" ...etc
@liminzhu
Copy link
Collaborator

@LouisLaf

@rwaldron
Copy link

Hi! Just want to to add to the report that eshost builds are failing on appveyor with the same error message.

@rwaldron rwaldron mentioned this issue Mar 13, 2019
Closed
@LouisLaf
Copy link
Collaborator

Yes, it looks like the VS 2015 builds are broken. CFGuard.h was added in VS 2017. I'll look into it.

@LouisLaf LouisLaf self-assigned this Mar 13, 2019
@LouisLaf LouisLaf mentioned this issue Mar 22, 2019
Merged
@LouisLaf
Copy link
Collaborator

VS2015 Update #3 should build fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LouisLaf LouisLaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rwaldron @liminzhu @xuechiyaobai @LouisLaf