-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use file path imports #318
fix: Use file path imports #318
Conversation
|
@g11tech My bad, tests should work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, waiting for @wemeetagain to give a look, @acolytec3 / @holgerd77 if you also want to review
I'll run our browser tests against it and see if we can remove our aliases in karma and let you know. |
let's merge it please, it's a blocker for some apps |
I checked this against our current master branch and the module resolution issues we had in our browser tests are no longer an issue. Can't wait to update our code with this. |
thanks @acolytec3 @paulmillr @FrederikBolding i have release the lib: #319, pls try the new versions |
@acolytec3 I have a branch ready for when the new version goes up. @g11tech I don't see it published on NPM quite yet. |
CI is still running, give it a few minutes |
Motivation
The goal of this PR is to stop relying on
package.json
exports
, as it may break older build tools such as Browserify.Description
Uses explicit imports for all imports that were previously using
exports
aliases.Steps to test or reproduce